From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Don Slutz <dslutz@verizon.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Anthony Liguori <aliguori@amazon.com>
Subject: [Qemu-devel] [PULL 04/12] test-qdev-global-props: Initialize not_used=true for all props
Date: Sun, 14 Sep 2014 21:41:27 +0300 [thread overview]
Message-ID: <1410719879-25181-5-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1410719879-25181-1-git-send-email-mst@redhat.com>
From: Eduardo Habkost <ehabkost@redhat.com>
This will ensure we are actually testing the code which sets
not_used=false when the property is used.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
tests/test-qdev-global-props.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tests/test-qdev-global-props.c b/tests/test-qdev-global-props.c
index 34223a7..5488937 100644
--- a/tests/test-qdev-global-props.c
+++ b/tests/test-qdev-global-props.c
@@ -164,8 +164,8 @@ static void test_dynamic_globalprop_subprocess(void)
{
MyType *mt;
static GlobalProperty props[] = {
- { TYPE_DYNAMIC_PROPS, "prop1", "101" },
- { TYPE_DYNAMIC_PROPS, "prop2", "102" },
+ { TYPE_DYNAMIC_PROPS, "prop1", "101", true },
+ { TYPE_DYNAMIC_PROPS, "prop2", "102", true },
{ TYPE_DYNAMIC_PROPS"-bad", "prop3", "103", true },
{}
};
@@ -180,6 +180,9 @@ static void test_dynamic_globalprop_subprocess(void)
g_assert_cmpuint(mt->prop2, ==, 102);
all_used = qdev_prop_check_global();
g_assert_cmpuint(all_used, ==, 1);
+ g_assert(!props[0].not_used);
+ g_assert(!props[1].not_used);
+ g_assert(props[2].not_used);
}
static void test_dynamic_globalprop(void)
--
MST
next prev parent reply other threads:[~2014-09-14 18:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 18:41 [Qemu-devel] [PULL 00/12] pci, pc, virtio, misc bugfixes Michael S. Tsirkin
2014-09-14 18:41 ` [Qemu-devel] [PULL 01/12] hw/machine: Free old values of string properties Michael S. Tsirkin
2014-09-14 18:41 ` [Qemu-devel] [PULL 02/12] test-qdev-global-props: Trivial comment fix Michael S. Tsirkin
2014-09-14 18:41 ` [Qemu-devel] [PULL 03/12] test-qdev-global-props: Run tests on subprocess Michael S. Tsirkin
2014-09-18 16:29 ` Michael Roth
2014-09-18 17:06 ` Paolo Bonzini
2014-09-18 17:38 ` Michael S. Tsirkin
2014-09-18 17:27 ` Eduardo Habkost
2014-09-18 17:44 ` Michael Roth
2014-09-14 18:41 ` Michael S. Tsirkin [this message]
2014-09-14 18:41 ` [Qemu-devel] [PULL 05/12] test-qdev-global-props: Test handling of hotpluggable and non-device types Michael S. Tsirkin
2014-09-14 18:41 ` [Qemu-devel] [PULL 06/12] qdev: Rename qdev_prop_check_global() to qdev_prop_check_globals() Michael S. Tsirkin
2014-09-14 18:41 ` [Qemu-devel] [PULL 07/12] qdev: Move global validation to a single function Michael S. Tsirkin
2014-09-14 18:41 ` [Qemu-devel] [PULL 08/12] Revert "rng-egd: remove redundant free" Michael S. Tsirkin
2014-09-14 18:41 ` [Qemu-devel] [PULL 09/12] virtio-net: drop assert on vm stop Michael S. Tsirkin
2014-09-14 18:41 ` [Qemu-devel] [PULL 10/12] Revert "virtio: don't call device on !vm_running" Michael S. Tsirkin
2014-09-14 18:41 ` [Qemu-devel] [PULL 11/12] virtio-pci: enable bus master for old guests Michael S. Tsirkin
2014-09-14 18:41 ` [Qemu-devel] [PULL 12/12] vhost-user: fix VIRTIO_NET_F_MRG_RXBUF negotiation Michael S. Tsirkin
2014-09-16 7:06 ` Linhaifeng
2014-09-16 15:57 ` Michael S. Tsirkin
2014-09-15 20:30 ` [Qemu-devel] [PULL 00/12] pci, pc, virtio, misc bugfixes Peter Maydell
2014-09-16 14:43 ` Michael S. Tsirkin
2014-09-16 14:07 ` Paolo Bonzini
2014-09-16 14:52 ` Michael S. Tsirkin
2014-09-18 16:37 ` Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410719879-25181-5-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@amazon.com \
--cc=dslutz@verizon.com \
--cc=ehabkost@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).