From: Gerd Hoffmann <kraxel@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] usb-storage: Fix how legacy init handles option ID clash
Date: Mon, 15 Sep 2014 08:40:49 +0200 [thread overview]
Message-ID: <1410763249.23112.11.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1410549874-15980-1-git-send-email-armbru@redhat.com>
On Fr, 2014-09-12 at 21:24 +0200, Markus Armbruster wrote:
> usb_msd_init() calls qemu_opts_create() with a made-up ID and false
> fail_if_exists. If the ID already exists, it happily messes up those
> options, then fails drive_new(), because the BlockDriverState with
> that ID already exists, too.
>
> Reproducer: -drive if=none,id=usb0,format=raw -usbdevice disk:tmp.qcow2
>
> Pass true fail_if_exists to qemu_opts_create(), and if it fails, try
> the next made-up ID.
>
> The reproducer now succeeds, and creates an usb-storage device with ID
> usb1.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Added to usb patch queue.
thanks,
Gerd
prev parent reply other threads:[~2014-09-15 6:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 19:24 [Qemu-devel] [PATCH] usb-storage: Fix how legacy init handles option ID clash Markus Armbruster
2014-09-15 6:40 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410763249.23112.11.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).