qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: hw.claudio@gmail.com
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Claudio Fontana <claudio.fontana@huawei.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [RFC] arm/virt: mark timer in fdt as armv8-compatible
Date: Mon, 15 Sep 2014 10:14:31 +0200	[thread overview]
Message-ID: <1410768871-1589-1-git-send-email-hw.claudio@gmail.com> (raw)

From: Claudio Fontana <claudio.fontana@huawei.com>

Signed-off-by: Claudio Fontana <claudio.fontana@huawei.com>
---
 hw/arm/virt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Is the timer armv8-compatible? I think it is, at least the virtual
timer seems to work as expected.

When looking up the timer information in the guest btw,
where the guest is running AArch64, does it make sense to look
for an armv8-timer compatible string?
Or is the "/timer" path standard enough that I should look for
the node using that fixed path instead?

Thanks,

Claudio

diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index d6fffc7..8dbaf9d 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -245,7 +245,7 @@ static void fdt_add_timer_nodes(const VirtBoardInfo *vbi)
 
     qemu_fdt_add_subnode(vbi->fdt, "/timer");
     qemu_fdt_setprop_string(vbi->fdt, "/timer",
-                                "compatible", "arm,armv7-timer");
+                                "compatible", "arm,armv7-timer,armv8-timer");
     qemu_fdt_setprop_cells(vbi->fdt, "/timer", "interrupts",
                                GIC_FDT_IRQ_TYPE_PPI, 13, irqflags,
                                GIC_FDT_IRQ_TYPE_PPI, 14, irqflags,
-- 
1.8.5.3

             reply	other threads:[~2014-09-15  8:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-15  8:14 hw.claudio [this message]
2014-09-16  9:31 ` [Qemu-devel] [RFC] arm/virt: mark timer in fdt as armv8-compatible Claudio Fontana
2014-09-25 17:15   ` Peter Maydell
2014-09-26 12:34     ` Claudio Fontana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410768871-1589-1-git-send-email-hw.claudio@gmail.com \
    --to=hw.claudio@gmail.com \
    --cc=claudio.fontana@huawei.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).