From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTRM6-0006oV-4W for qemu-devel@nongnu.org; Mon, 15 Sep 2014 04:09:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTRLw-0000O8-Kg for qemu-devel@nongnu.org; Mon, 15 Sep 2014 04:09:50 -0400 Received: from mail-la0-x22d.google.com ([2a00:1450:4010:c03::22d]:34867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTRLw-0000Nx-Db for qemu-devel@nongnu.org; Mon, 15 Sep 2014 04:09:40 -0400 Received: by mail-la0-f45.google.com with SMTP id b17so4127844lan.4 for ; Mon, 15 Sep 2014 01:09:39 -0700 (PDT) From: hw.claudio@gmail.com Date: Mon, 15 Sep 2014 10:14:31 +0200 Message-Id: <1410768871-1589-1-git-send-email-hw.claudio@gmail.com> Subject: [Qemu-devel] [RFC] arm/virt: mark timer in fdt as armv8-compatible List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Claudio Fontana , qemu-devel@nongnu.org From: Claudio Fontana Signed-off-by: Claudio Fontana --- hw/arm/virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Is the timer armv8-compatible? I think it is, at least the virtual timer seems to work as expected. When looking up the timer information in the guest btw, where the guest is running AArch64, does it make sense to look for an armv8-timer compatible string? Or is the "/timer" path standard enough that I should look for the node using that fixed path instead? Thanks, Claudio diff --git a/hw/arm/virt.c b/hw/arm/virt.c index d6fffc7..8dbaf9d 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -245,7 +245,7 @@ static void fdt_add_timer_nodes(const VirtBoardInfo *vbi) qemu_fdt_add_subnode(vbi->fdt, "/timer"); qemu_fdt_setprop_string(vbi->fdt, "/timer", - "compatible", "arm,armv7-timer"); + "compatible", "arm,armv7-timer,armv8-timer"); qemu_fdt_setprop_cells(vbi->fdt, "/timer", "interrupts", GIC_FDT_IRQ_TYPE_PPI, 13, irqflags, GIC_FDT_IRQ_TYPE_PPI, 14, irqflags, -- 1.8.5.3