From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTXpD-0008T6-3A for qemu-devel@nongnu.org; Mon, 15 Sep 2014 11:04:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTXp3-0007wr-G2 for qemu-devel@nongnu.org; Mon, 15 Sep 2014 11:04:19 -0400 Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:32948) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTXp3-0007v5-5M for qemu-devel@nongnu.org; Mon, 15 Sep 2014 11:04:09 -0400 Received: by mail-we0-f176.google.com with SMTP id q58so4086284wes.35 for ; Mon, 15 Sep 2014 08:04:08 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 15 Sep 2014 17:03:37 +0200 Message-Id: <1410793421-6453-11-git-send-email-pbonzini@redhat.com> In-Reply-To: <1410793421-6453-1-git-send-email-pbonzini@redhat.com> References: <1410793421-6453-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 10/14] ppc: use movcond for isel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: tommusta@gmail.com, agraf@suse.de Signed-off-by: Paolo Bonzini --- v1->v2: fixed TCG debugging failures target-ppc/translate.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 9ff8763..0933c00 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -777,27 +777,27 @@ static void gen_cmpli(DisasContext *ctx) /* isel (PowerPC 2.03 specification) */ static void gen_isel(DisasContext *ctx) { - int l1, l2; uint32_t bi = rC(ctx->opcode); uint32_t mask; TCGv_i32 t0; - - l1 = gen_new_label(); - l2 = gen_new_label(); + TCGv t1, true_op, zero; mask = 0x08 >> (bi & 0x03); t0 = tcg_temp_new_i32(); tcg_gen_andi_i32(t0, cpu_crf[bi >> 2], mask); - tcg_gen_brcondi_i32(TCG_COND_EQ, t0, 0, l1); - if (rA(ctx->opcode) == 0) - tcg_gen_movi_tl(cpu_gpr[rD(ctx->opcode)], 0); - else - tcg_gen_mov_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]); - tcg_gen_br(l2); - gen_set_label(l1); - tcg_gen_mov_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rB(ctx->opcode)]); - gen_set_label(l2); + t1 = tcg_temp_new(); + tcg_gen_extu_i32_tl(t1, t0); + zero = tcg_const_tl(0); + if (rA(ctx->opcode) == 0) { + true_op = zero; + } else { + true_op = cpu_gpr[rA(ctx->opcode)]; + } + tcg_gen_movcond_tl(TCG_COND_NE, cpu_gpr[rD(ctx->opcode)], t1, zero, + true_op, cpu_gpr[rB(ctx->opcode)]); + tcg_temp_free(t1); tcg_temp_free_i32(t0); + tcg_temp_free(zero); } /* cmpb: PowerPC 2.05 specification */ -- 1.8.3.1