From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTXp6-0008Hu-K8 for qemu-devel@nongnu.org; Mon, 15 Sep 2014 11:04:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTXox-0007m8-1e for qemu-devel@nongnu.org; Mon, 15 Sep 2014 11:04:12 -0400 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:56335) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTXow-0007lp-R5 for qemu-devel@nongnu.org; Mon, 15 Sep 2014 11:04:02 -0400 Received: by mail-wi0-f175.google.com with SMTP id cc10so4419081wib.2 for ; Mon, 15 Sep 2014 08:04:02 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 15 Sep 2014 17:03:34 +0200 Message-Id: <1410793421-6453-8-git-send-email-pbonzini@redhat.com> In-Reply-To: <1410793421-6453-1-git-send-email-pbonzini@redhat.com> References: <1410793421-6453-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 07/14] ppc: reorganize gen_compute_fprf List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: tommusta@gmail.com, agraf@suse.de Signed-off-by: Paolo Bonzini --- v1->v2: fixed leak of temporaries target-ppc/translate.c | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index c28bddf..a8b6b7c 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -252,23 +252,22 @@ static inline void gen_reset_fpstatus(void) static inline void gen_compute_fprf(TCGv_i64 arg, int set_fprf, int set_rc) { - TCGv_i32 t0 = tcg_temp_new_i32(); + TCGv_i32 t0; - if (set_fprf != 0) { - /* This case might be optimized later */ - tcg_gen_movi_i32(t0, 1); - gen_helper_compute_fprf(t0, cpu_env, arg, t0); - if (unlikely(set_rc)) { - tcg_gen_mov_i32(cpu_crf[1], t0); - } - gen_helper_float_check_status(cpu_env); - } else if (unlikely(set_rc)) { - /* We always need to compute fpcc */ - tcg_gen_movi_i32(t0, 0); - gen_helper_compute_fprf(t0, cpu_env, arg, t0); + if (set_fprf == 0 && !set_rc) { + return; + } + + t0 = tcg_temp_new_i32(); + tcg_gen_movi_i32(t0, set_fprf != 0); + gen_helper_compute_fprf(t0, cpu_env, arg, t0); + if (set_rc) { tcg_gen_mov_i32(cpu_crf[1], t0); } + if (set_fprf != 0) { + gen_helper_float_check_status(cpu_env); + } tcg_temp_free_i32(t0); } -- 1.8.3.1