From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: qemu-devel@nongnu.org
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>,
luonengjun@huawei.com, peter.huangpeng@huawei.com,
lcapitulino@redhat.com, qiaonuohan@cn.fujitsu.com,
lersek@redhat.com
Subject: [Qemu-devel] [PATCH v5 0/2] Fix dump_error to return error message
Date: Tue, 16 Sep 2014 15:30:57 +0800 [thread overview]
Message-ID: <1410852659-13856-1-git-send-email-zhang.zhanghailiang@huawei.com> (raw)
Hi,
In original code, Function dump_error ignores its second parameter which contains
error reason, it is better to return the error message to the caller.
Here we use error_setg to return the error info to caller.
And at the same time, we turn functions like write_elf64_note() to void,
Because functions shouldn't return an error code _and_ an Error object.
After this modification the code will be more clean.
V4 -> V5:
- Turn functions like write_elf64_note() to void (advised by Luiz Capitulino)
V3 -> V4:
- Adjust the errp argument to the end
- Remove trailing '.' in error messages
V2 -> V3:
- Drop the '\n' in the message when call dump_error(comment of Eric Blake)
V1 -> V2:
- Return the error reason to the caller which suggested by Luiz Capitulino.
zhanghailiang (2):
dump: let dump_error return error info to caller
dump: Don't return error code when return an Error object
dump.c | 333 +++++++++++++++++++++++++++--------------------------------------
1 file changed, 138 insertions(+), 195 deletions(-)
--
1.7.12.4
next reply other threads:[~2014-09-16 7:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 7:30 zhanghailiang [this message]
2014-09-16 7:30 ` [Qemu-devel] [PATCH v5 1/2] dump: let dump_error return error info to caller zhanghailiang
2014-09-16 7:30 ` [Qemu-devel] [PATCH v5 2/2] dump: Don't return error code when return an Error object zhanghailiang
2014-09-16 16:24 ` Markus Armbruster
2014-09-19 0:51 ` zhanghailiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410852659-13856-1-git-send-email-zhang.zhanghailiang@huawei.com \
--to=zhang.zhanghailiang@huawei.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=luonengjun@huawei.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qiaonuohan@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).