From: Gerd Hoffmann <kraxel@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vnc-tls: Clean up dead store in vnc_set_x509_credential()
Date: Wed, 17 Sep 2014 13:40:10 +0200 [thread overview]
Message-ID: <1410954010.32607.12.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1410939195-1309-1-git-send-email-armbru@redhat.com>
On Mi, 2014-09-17 at 09:33 +0200, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> ui/vnc-tls.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/ui/vnc-tls.c b/ui/vnc-tls.c
> index 6392326..0f59f9b 100644
> --- a/ui/vnc-tls.c
> +++ b/ui/vnc-tls.c
> @@ -444,8 +444,6 @@ static int vnc_set_x509_credential(VncDisplay *vd,
> struct stat sb;
>
> g_free(*cred);
> - *cred = NULL;
> -
> *cred = g_malloc(strlen(certdir) + strlen(filename) + 2);
>
> strcpy(*cred, certdir);
added to vnc patch queue
thanks,
Gerd
prev parent reply other threads:[~2014-09-17 11:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 7:33 [Qemu-devel] [PATCH] vnc-tls: Clean up dead store in vnc_set_x509_credential() Markus Armbruster
2014-09-17 11:40 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410954010.32607.12.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).