* [Qemu-devel] [PATCH] vnc-tls: Clean up dead store in vnc_set_x509_credential()
@ 2014-09-17 7:33 Markus Armbruster
2014-09-17 11:40 ` Gerd Hoffmann
0 siblings, 1 reply; 2+ messages in thread
From: Markus Armbruster @ 2014-09-17 7:33 UTC (permalink / raw)
To: qemu-devel; +Cc: kraxel
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
ui/vnc-tls.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/ui/vnc-tls.c b/ui/vnc-tls.c
index 6392326..0f59f9b 100644
--- a/ui/vnc-tls.c
+++ b/ui/vnc-tls.c
@@ -444,8 +444,6 @@ static int vnc_set_x509_credential(VncDisplay *vd,
struct stat sb;
g_free(*cred);
- *cred = NULL;
-
*cred = g_malloc(strlen(certdir) + strlen(filename) + 2);
strcpy(*cred, certdir);
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] vnc-tls: Clean up dead store in vnc_set_x509_credential()
2014-09-17 7:33 [Qemu-devel] [PATCH] vnc-tls: Clean up dead store in vnc_set_x509_credential() Markus Armbruster
@ 2014-09-17 11:40 ` Gerd Hoffmann
0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2014-09-17 11:40 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel
On Mi, 2014-09-17 at 09:33 +0200, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> ui/vnc-tls.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/ui/vnc-tls.c b/ui/vnc-tls.c
> index 6392326..0f59f9b 100644
> --- a/ui/vnc-tls.c
> +++ b/ui/vnc-tls.c
> @@ -444,8 +444,6 @@ static int vnc_set_x509_credential(VncDisplay *vd,
> struct stat sb;
>
> g_free(*cred);
> - *cred = NULL;
> -
> *cred = g_malloc(strlen(certdir) + strlen(filename) + 2);
>
> strcpy(*cred, certdir);
added to vnc patch queue
thanks,
Gerd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-17 11:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-17 7:33 [Qemu-devel] [PATCH] vnc-tls: Clean up dead store in vnc_set_x509_credential() Markus Armbruster
2014-09-17 11:40 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).