From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35885)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XUDaw-00082P-JJ
	for qemu-devel@nongnu.org; Wed, 17 Sep 2014 07:40:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XUDaq-00032L-CM
	for qemu-devel@nongnu.org; Wed, 17 Sep 2014 07:40:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30195)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XUDaq-0002zr-4x
	for qemu-devel@nongnu.org; Wed, 17 Sep 2014 07:40:16 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8HBeCj7002045
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 17 Sep 2014 07:40:12 -0400
Message-ID: <1410954010.32607.12.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 17 Sep 2014 13:40:10 +0200
In-Reply-To: <1410939195-1309-1-git-send-email-armbru@redhat.com>
References: <1410939195-1309-1-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vnc-tls: Clean up dead store in
 vnc_set_x509_credential()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On Mi, 2014-09-17 at 09:33 +0200, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  ui/vnc-tls.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/ui/vnc-tls.c b/ui/vnc-tls.c
> index 6392326..0f59f9b 100644
> --- a/ui/vnc-tls.c
> +++ b/ui/vnc-tls.c
> @@ -444,8 +444,6 @@ static int vnc_set_x509_credential(VncDisplay *vd,
>      struct stat sb;
>  
>      g_free(*cred);
> -    *cred = NULL;
> -
>      *cred = g_malloc(strlen(certdir) + strlen(filename) + 2);
>  
>      strcpy(*cred, certdir);

added to vnc patch queue

thanks,
  Gerd