qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Owen smith <owen.smith@citrix.com>
To: qemu-devel@nongnu.org
Cc: stefano.stabellini@eu.citrix.com,
	Owen smith <owen.smith@citrix.com>,
	xen-devel@lists.xen.org
Subject: [Qemu-devel] [PATCH v2 2/5] xenfb: Activate mouse event handler
Date: Wed, 17 Sep 2014 15:30:39 +0100	[thread overview]
Message-ID: <1410964242-3341-3-git-send-email-owen.smith@citrix.com> (raw)
In-Reply-To: <1410964242-3341-1-git-send-email-owen.smith@citrix.com>

Without activating the mouse event handler, mouse events are not
delivered to the new handler. Input events are only delivered to
the first matching handler in the input chain. Activating a handler
moves the handler to the start of the chain.

Note: qemu_add_kbd_event_handler adds and activates the keyboard
handler, where qemu_add_mouse_event_handler does not activate the
mouse handler.

Signed-off-by: Owen smith <owen.smith@citrix.com>
---
 hw/display/xenfb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
index 9dcf9b6..69471e9 100644
--- a/hw/display/xenfb.c
+++ b/hw/display/xenfb.c
@@ -383,6 +383,7 @@ static void input_connected(struct XenDevice *xendev)
     in->qmouse = qemu_add_mouse_event_handler(xenfb_mouse_event, in,
 					      in->abs_pointer_wanted,
 					      "Xen PVFB Mouse");
+    qemu_activate_mouse_event_handler(in->qmouse);
 
     if (in->qkbd) {
         qemu_remove_kbd_event_handler(in->qkbd);
-- 
2.1.0

  parent reply	other threads:[~2014-09-17 14:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17 14:30 [Qemu-devel] [PATCH v2 0/5] xenfb: Add support for Windows PV frontend Owen smith
2014-09-17 14:30 ` [Qemu-devel] [PATCH v2 1/5] xenfb: Unregister keyboard event handler correctly Owen smith
2014-09-26 15:10   ` Stefano Stabellini
2014-09-17 14:30 ` Owen smith [this message]
2014-09-26 15:12   ` [Qemu-devel] [PATCH v2 2/5] xenfb: Activate mouse event handler Stefano Stabellini
2014-09-17 14:30 ` [Qemu-devel] [PATCH v2 3/5] xenfb: Add option to use a grant ref for shared page Owen smith
2014-09-17 16:42   ` [Qemu-devel] [Xen-devel] " Ian Campbell
2014-09-26 15:17   ` [Qemu-devel] " Stefano Stabellini
2014-09-17 14:30 ` [Qemu-devel] [PATCH v2 4/5] xenfb: Add "feature-no-abs-rescale" Owen smith
2014-09-26 15:25   ` Stefano Stabellini
2014-09-17 14:30 ` [Qemu-devel] [PATCH v2 5/5] xenfb: Add "feature-no-console" Owen smith
2014-09-26 15:42   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410964242-3341-3-git-send-email-owen.smith@citrix.com \
    --to=owen.smith@citrix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).