From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUIK2-00080L-0F for qemu-devel@nongnu.org; Wed, 17 Sep 2014 12:43:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUIJp-00046Y-Dy for qemu-devel@nongnu.org; Wed, 17 Sep 2014 12:43:13 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:47680) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUIJp-00044r-9W for qemu-devel@nongnu.org; Wed, 17 Sep 2014 12:43:01 -0400 Message-ID: <1410972171.23505.45.camel@citrix.com> From: Ian Campbell Date: Wed, 17 Sep 2014 17:42:51 +0100 In-Reply-To: <1410964242-3341-4-git-send-email-owen.smith@citrix.com> References: <1410964242-3341-1-git-send-email-owen.smith@citrix.com> <1410964242-3341-4-git-send-email-owen.smith@citrix.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH v2 3/5] xenfb: Add option to use a grant ref for shared page List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Owen smith Cc: xen-devel@lists.xen.org, qemu-devel@nongnu.org, stefano.stabellini@eu.citrix.com On Wed, 2014-09-17 at 15:30 +0100, Owen smith wrote: > Adds "page-gref" to the frontend location to specify the grant xen.git/xen/include/public/io/fbif.h is a bit sparse in terms of docs right now, but could I encourage you to add the new keys which you are implementing in this series to it please? (If you were minded to also document the other existing ones at the same time that would be super-awesome(tm)). Ian.