From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUMqo-0002AF-33 for qemu-devel@nongnu.org; Wed, 17 Sep 2014 17:33:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUMqg-00032P-Hg for qemu-devel@nongnu.org; Wed, 17 Sep 2014 17:33:22 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:32926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUMqg-00030x-AB for qemu-devel@nongnu.org; Wed, 17 Sep 2014 17:33:14 -0400 Received: from /spool/local by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 17 Sep 2014 15:33:07 -0600 From: Michael Roth Date: Wed, 17 Sep 2014 16:32:52 -0500 Message-Id: <1410989576-9311-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH v2 0/4] qapi: fix crash in dealloc visitor for union types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: famz@redhat.com, armbru@redhat.com, qemu-stable@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com This series introduces visit_start_union and visit_end_union as a way of allowing visitors to trigger generated code to bail out on visiting union fields if the visitor implementation deems doing so to be unsafe. See patch 1 for the circumstances that cause the segfault in the dealloc visitor. This is a spin-off of a patch submitted by Fam Zheng earlier. See the thread for additional background on why we're taking this approach: http://thread.gmane.org/gmane.comp.emulators.qemu/296090 v2: * added comments to clarify true/false visit_start_union vs. errp in dealloc visitor implementation (Eric) * fixed a line that was >80 characters (Eric) * fixed extra period in patch 2 commit msg (Eric) * added comments to note reasons why the interface is useable for dealloc visitor, but may require extra QAPI groundwork and interface parameters to be useful for other types of visitors * included Fam's qemu-iotest test case to exercise bug fix in a user-triggerable scenario. include/qapi/visitor-impl.h | 2 ++ include/qapi/visitor.h | 2 ++ qapi/qapi-dealloc-visitor.c | 26 ++++++++++++++++++++++++++ qapi/qapi-visit-core.c | 15 +++++++++++++++ scripts/qapi-visit.py | 6 ++++++ tests/qapi-schema/qapi-schema-test.json | 10 ++++++++++ tests/qapi-schema/qapi-schema-test.out | 3 +++ tests/qemu-iotests/087 | 17 +++++++++++++++++ tests/qemu-iotests/087.out | 13 +++++++++++++ tests/test-qmp-input-strict.c | 17 +++++++++++++++++ 10 files changed, 111 insertions(+)