[Qemu-devel] [PULL 0/2] vnc patch queue

[Qemu-devel] [PULL 0/2] vnc patch queue

[Gerd Hoffmann]

  Hi,

Two little vnc patches.

please pull,
  Gerd

The following changes since commit e4d50d47a9eb15f42bdd561803a29a4d7c3eb8ec:

  qemu-char: Rename register_char_driver_qapi() to register_char_driver() (2014-09-16 23:36:32 +0100)

are available in the git repository at:

  git://git.kraxel.org/qemu tags/pull-vnc-20140918-1

for you to fetch changes up to 9d64fab42274fb50a39bab184f79d0239596ba4a:

  vnc-tls: Clean up dead store in vnc_set_x509_credential() (2014-09-18 08:01:53 +0200)

----------------------------------------------------------------
vnc: set TCP_NODELAY, cleanup in tlc code

----------------------------------------------------------------
Markus Armbruster (1):
      vnc-tls: Clean up dead store in vnc_set_x509_credential()

Peter Lieven (1):
      ui/vnc: set TCP_NODELAY

 ui/vnc-tls.c | 2 --
 ui/vnc.c     | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)

[Qemu-devel] [PULL 1/2] ui/vnc: set TCP_NODELAY

[Gerd Hoffmann]

From: Peter Lieven <pl@kamp.de>

we currently have the Nagle algorithm enabled for all outgoing VNC updates.
This may delay sensitive updates as mouse movements or typing in the console.
As we currently prepare all data in a buffer and then send as much as we can
disabling the Nagle algorithm should not cause big trouble. Well established
VNC servers like TightVNC set TCP_NODELAY as well.
A regular framebuffer update request generates exactly one framebuffer update
which should be pushed out as fast as possible.

Signed-off-by: Peter Lieven <pl@kamp.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 ui/vnc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ui/vnc.c b/ui/vnc.c
index f8d9b7d..0fe6eff 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -2914,6 +2914,7 @@ static void vnc_listen_read(void *opaque, bool websocket)
     }
 
     if (csock != -1) {
+        socket_set_nodelay(csock);
         vnc_connect(vs, csock, false, websocket);
     }
 }
-- 
1.8.3.1

[Qemu-devel] [PULL 2/2] vnc-tls: Clean up dead store in vnc_set_x509_credential()

[Gerd Hoffmann]

From: Markus Armbruster <armbru@redhat.com>

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 ui/vnc-tls.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/ui/vnc-tls.c b/ui/vnc-tls.c
index 6392326..0f59f9b 100644
--- a/ui/vnc-tls.c
+++ b/ui/vnc-tls.c
@@ -444,8 +444,6 @@ static int vnc_set_x509_credential(VncDisplay *vd,
     struct stat sb;
 
     g_free(*cred);
-    *cred = NULL;
-
     *cred = g_malloc(strlen(certdir) + strlen(filename) + 2);
 
     strcpy(*cred, certdir);
-- 
1.8.3.1

Re: [Qemu-devel] [PULL 0/2] vnc patch queue

[Peter Maydell]

On 17 September 2014 23:33, Gerd Hoffmann <kraxel@redhat.com> wrote:
>   Hi,
>
> Two little vnc patches.
>
> please pull,
>   Gerd
>
> The following changes since commit e4d50d47a9eb15f42bdd561803a29a4d7c3eb8ec:
>
>   qemu-char: Rename register_char_driver_qapi() to register_char_driver() (2014-09-16 23:36:32 +0100)
>
> are available in the git repository at:
>
>   git://git.kraxel.org/qemu tags/pull-vnc-20140918-1
>
> for you to fetch changes up to 9d64fab42274fb50a39bab184f79d0239596ba4a:
>
>   vnc-tls: Clean up dead store in vnc_set_x509_credential() (2014-09-18 08:01:53 +0200)
>
> ----------------------------------------------------------------
> vnc: set TCP_NODELAY, cleanup in tlc code
>
> ----------------------------------------------------------------
> Markus Armbruster (1):
>       vnc-tls: Clean up dead store in vnc_set_x509_credential()
>
> Peter Lieven (1):
>       ui/vnc: set TCP_NODELAY
>
>  ui/vnc-tls.c | 2 --
>  ui/vnc.c     | 1 +
>  2 files changed, 1 insertion(+), 2 deletions(-)

Applied, thanks.

-- PMM