qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Chrysostomos Nanakos <cnanakos@grnet.gr>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Chrysostomos Nanakos <cnanakos@grnet.gr>,
	pingfank@linux.vnet.ibm.com, famz@redhat.com, benoit@irqsave.net,
	jan.kiszka@siemens.com, stefanha@redhat.com, mjt@tls.msk.ru,
	kroosec@gmail.com, sw@weilnetz.de, pbonzini@redhat.com,
	afaerber@suse.de, aliguori@amazon.com
Subject: [Qemu-devel] [PATCH v5 0/1] async: aio_context_new(): Handle event_notifier_init failure
Date: Thu, 18 Sep 2014 14:30:48 +0300	[thread overview]
Message-ID: <1411039850-1385-1-git-send-email-cnanakos@grnet.gr> (raw)

v4->v5
------
* Set thread_id before calling aio_context_new(). That way qmp_query_iothreads()
  will display thread_id -1 for a failed IOThread object than an uninitialized
  value.
* qemu_init_main_loop() will return -EMFILE if aio_context_new() fail. The
  actual failure reason is placed in the propagated error message.
* Initialize 'Error *local_error' value to NULL.

v3->v4
------
* Remove escaped single quotes from error messages.
* Rephrase commit log.

v2->v3
------
* Remove errno usage and print the detailed message based on errno when
  event_notifier_init() fails.
* Propagate error and return from iothread_complete() if aio_context_new() fails.
* Return if !iothread->ctx from iothread_instance_finalize(), used by QOM
  when object_unref(obj) is called after user_creatable_complete() fails.
* Remove cosmetic fixes accidentally introduced by editor and fix code style
  issues.

v1->v2
------
* aio_context_new() returns NULL if the initialization of event notifier fails.
* Add descriptive error messages if aio_context_new() and event_notifier_init()
  fail.
* Fix gpollfds leak.


Chrysostomos Nanakos (1):
  async: aio_context_new(): Handle event_notifier_init failure

 async.c                  |   16 +++++++++++-----
 include/block/aio.h      |    2 +-
 include/qemu/main-loop.h |    2 +-
 iothread.c               |   11 ++++++++++-
 main-loop.c              |    9 +++++++--
 qemu-img.c               |    8 +++++++-
 qemu-io.c                |    7 ++++++-
 qemu-nbd.c               |    6 +++++-
 tests/test-aio.c         |   10 +++++++++-
 tests/test-thread-pool.c |   10 +++++++++-
 tests/test-throttle.c    |   10 +++++++++-
 vl.c                     |    5 +++--
 12 files changed, 78 insertions(+), 18 deletions(-)

-- 
1.7.10.4

             reply	other threads:[~2014-09-18 11:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-18 11:30 Chrysostomos Nanakos [this message]
2014-09-18 11:30 ` [Qemu-devel] [PATCH v5 1/1] async: aio_context_new(): Handle event_notifier_init failure Chrysostomos Nanakos
2014-09-19 10:14 ` [Qemu-devel] [PATCH v5 0/1] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411039850-1385-1-git-send-email-cnanakos@grnet.gr \
    --to=cnanakos@grnet.gr \
    --cc=afaerber@suse.de \
    --cc=aliguori@amazon.com \
    --cc=benoit@irqsave.net \
    --cc=famz@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kroosec@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=pingfank@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).