qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: jsnow@redhat.com, armbru@redhat.com
Subject: [Qemu-devel] [RFC v2 3/3] ahci: implement -cdrom and -hd[a-d]
Date: Thu, 18 Sep 2014 13:59:06 -0400	[thread overview]
Message-ID: <1411063146-24058-4-git-send-email-jsnow@redhat.com> (raw)
In-Reply-To: <1411063146-24058-1-git-send-email-jsnow@redhat.com>

Signed-off-by: John Snow <jsnow@redhat.com>
---
 hw/i386/pc_q35.c |  3 +++
 hw/ide/ahci.c    | 31 +++++++++++++++++++++++++++++++
 hw/ide/ahci.h    |  3 +++
 3 files changed, 37 insertions(+)

diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index fd26fe1..0f33696 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -86,6 +86,7 @@ static void pc_q35_init(MachineState *machine)
     DeviceState *icc_bridge;
     PcGuestInfo *guest_info;
     ram_addr_t lowmem;
+    DriveInfo *hd[MAX_SATA_PORTS];
 
     /* Check whether RAM fits below 4G (leaving 1/2 GByte for IO memory
      * and 256 Mbytes for PCI Express Enhanced Configuration Access Mapping
@@ -253,6 +254,8 @@ static void pc_q35_init(MachineState *machine)
                                            true, "ich9-ahci");
     idebus[0] = qdev_get_child_bus(&ahci->qdev, "ide.0");
     idebus[1] = qdev_get_child_bus(&ahci->qdev, "ide.1");
+    ahci_drive_get(ahci, hd);
+    ahci_ide_create_devs(ahci, hd);
 
     if (usb_enabled(false)) {
         /* Should we create 6 UHCI according to ich9 spec? */
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index ba69de3..ae28de4 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -1402,3 +1402,34 @@ static void sysbus_ahci_register_types(void)
 }
 
 type_init(sysbus_ahci_register_types)
+
+void ahci_drive_get(PCIDevice *dev, DriveInfo **tab)
+{
+    AHCIPCIState *d = ICH_AHCI(dev);
+    AHCIState *ahci = &d->ahci;
+    unsigned i;
+
+    if ((i = drive_get_max_bus(IF_IDE)) >= ahci->ports) {
+        fprintf(stderr, "AHCI: Too many IDE buses defined for AHCI (%d > %d)\n",
+                i, ahci->ports - 1);
+    }
+
+    for (i = 0; i < ahci->ports; ++i) {
+        tab[i] = drive_get_by_index(IF_IDE, i);
+    }
+}
+
+void ahci_ide_create_devs(PCIDevice *dev, DriveInfo **tab)
+{
+    AHCIPCIState *d = ICH_AHCI(dev);
+    AHCIState *ahci = &d->ahci;
+    unsigned i;
+
+    for (i = 0; i < ahci->ports; i++) {
+        if (tab[i] == NULL) {
+            continue;
+        }
+        ide_create_drive(&ahci->dev[i].port, 0, tab[i]);
+    }
+
+}
diff --git a/hw/ide/ahci.h b/hw/ide/ahci.h
index 1543df7..06a18de 100644
--- a/hw/ide/ahci.h
+++ b/hw/ide/ahci.h
@@ -332,4 +332,7 @@ void ahci_uninit(AHCIState *s);
 
 void ahci_reset(AHCIState *s);
 
+void ahci_drive_get(PCIDevice *dev, DriveInfo **tab);
+void ahci_ide_create_devs(PCIDevice *dev, DriveInfo **tab);
+
 #endif /* HW_IDE_AHCI_H */
-- 
1.9.3

  parent reply	other threads:[~2014-09-18 17:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-18 17:59 [Qemu-devel] [RFC v2 0/3] Q35/AHCI -cdrom/-hda desugaring John Snow
2014-09-18 17:59 ` [Qemu-devel] [RFC v2 1/3] blockdev: Add function to search for orphaned drives John Snow
2014-09-19  8:28   ` Markus Armbruster
2014-09-19 15:50     ` John Snow
2014-09-18 17:59 ` [Qemu-devel] [RFC v2 2/3] Add units-per-idebus property John Snow
2014-09-19  9:39   ` Markus Armbruster
2014-09-21  9:34     ` Marcel Apfelbaum
2014-09-22  7:51       ` Markus Armbruster
2014-09-18 17:59 ` John Snow [this message]
2014-09-19  9:49   ` [Qemu-devel] [RFC v2 3/3] ahci: implement -cdrom and -hd[a-d] Markus Armbruster
2014-09-19  9:53 ` [Qemu-devel] [RFC v2 0/3] Q35/AHCI -cdrom/-hda desugaring Markus Armbruster
2014-09-22 23:17   ` John Snow
2014-09-23  7:36     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411063146-24058-4-git-send-email-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).