qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Marcel Apfelbaum" <marcel.a@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	qemu-stable@nongnu.org, "Le Tan" <tamlokveer@gmail.com>,
	"Anthony Liguori" <aliguori@amazon.com>,
	"Amos Kong" <akong@redhat.com>,
	=?UTF-8?q?Andreas=20F=C3=A4rber?= <afaerber@suse.de>
Subject: [Qemu-devel] [PULL v2 01/15] hw/machine: Free old values of string properties
Date: Thu, 18 Sep 2014 21:18:16 +0300	[thread overview]
Message-ID: <1411063757-29216-2-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1411063757-29216-1-git-send-email-mst@redhat.com>

From: Eduardo Habkost <ehabkost@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel.a@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Amos Kong <akong@redhat.com>
Cc: qemu-stable@nongnu.org
---
 hw/core/machine.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/hw/core/machine.c b/hw/core/machine.c
index f0046d6..7f3418c 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -24,6 +24,7 @@ static void machine_set_accel(Object *obj, const char *value, Error **errp)
 {
     MachineState *ms = MACHINE(obj);
 
+    g_free(ms->accel);
     ms->accel = g_strdup(value);
 }
 
@@ -79,6 +80,7 @@ static void machine_set_kernel(Object *obj, const char *value, Error **errp)
 {
     MachineState *ms = MACHINE(obj);
 
+    g_free(ms->kernel_filename);
     ms->kernel_filename = g_strdup(value);
 }
 
@@ -93,6 +95,7 @@ static void machine_set_initrd(Object *obj, const char *value, Error **errp)
 {
     MachineState *ms = MACHINE(obj);
 
+    g_free(ms->initrd_filename);
     ms->initrd_filename = g_strdup(value);
 }
 
@@ -107,6 +110,7 @@ static void machine_set_append(Object *obj, const char *value, Error **errp)
 {
     MachineState *ms = MACHINE(obj);
 
+    g_free(ms->kernel_cmdline);
     ms->kernel_cmdline = g_strdup(value);
 }
 
@@ -121,6 +125,7 @@ static void machine_set_dtb(Object *obj, const char *value, Error **errp)
 {
     MachineState *ms = MACHINE(obj);
 
+    g_free(ms->dtb);
     ms->dtb = g_strdup(value);
 }
 
@@ -135,6 +140,7 @@ static void machine_set_dumpdtb(Object *obj, const char *value, Error **errp)
 {
     MachineState *ms = MACHINE(obj);
 
+    g_free(ms->dumpdtb);
     ms->dumpdtb = g_strdup(value);
 }
 
@@ -176,6 +182,7 @@ static void machine_set_dt_compatible(Object *obj, const char *value, Error **er
 {
     MachineState *ms = MACHINE(obj);
 
+    g_free(ms->dt_compatible);
     ms->dt_compatible = g_strdup(value);
 }
 
@@ -232,6 +239,7 @@ static void machine_set_firmware(Object *obj, const char *value, Error **errp)
 {
     MachineState *ms = MACHINE(obj);
 
+    g_free(ms->firmware);
     ms->firmware = g_strdup(value);
 }
 
-- 
MST

  parent reply	other threads:[~2014-09-18 18:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-18 18:10 [Qemu-devel] [PULL v2 00/15] pci, pc, virtio, misc bugfixes Michael S. Tsirkin
2014-09-18 18:10 ` [Qemu-devel] [PULL v2 02/15] test-qdev-global-props: Trivial comment fix Michael S. Tsirkin
2014-09-18 18:10 ` [Qemu-devel] [PULL v2 03/15] test-qdev-global-props: Run tests on subprocess Michael S. Tsirkin
2014-09-18 18:10 ` [Qemu-devel] [PULL v2 04/15] test-qdev-global-props: Initialize not_used=true for all props Michael S. Tsirkin
2014-09-18 18:10 ` [Qemu-devel] [PULL v2 05/15] test-qdev-global-props: Test handling of hotpluggable and non-device types Michael S. Tsirkin
2014-09-18 18:10 ` [Qemu-devel] [PULL v2 06/15] qdev: Rename qdev_prop_check_global() to qdev_prop_check_globals() Michael S. Tsirkin
2014-09-18 18:18 ` Michael S. Tsirkin [this message]
2014-09-18 18:18 ` [Qemu-devel] [PULL v2 07/15] qdev: Move global validation to a single function Michael S. Tsirkin
2014-09-18 18:18 ` [Qemu-devel] [PULL v2 08/15] Revert "rng-egd: remove redundant free" Michael S. Tsirkin
2014-09-18 18:18 ` [Qemu-devel] [PULL v2 09/15] virtio-net: drop assert on vm stop Michael S. Tsirkin
2014-09-18 18:18 ` [Qemu-devel] [PULL v2 10/15] Revert "virtio: don't call device on !vm_running" Michael S. Tsirkin
2014-09-18 18:18 ` [Qemu-devel] [PULL v2 11/15] virtio-pci: enable bus master for old guests Michael S. Tsirkin
2014-09-18 18:18 ` [Qemu-devel] [PULL v2 12/15] vhost-user: fix VIRTIO_NET_F_MRG_RXBUF negotiation Michael S. Tsirkin
2014-09-18 18:19 ` [Qemu-devel] [PULL v2 13/15] virtio-pci: fix migration for pci bus master Michael S. Tsirkin
2014-09-18 18:19 ` [Qemu-devel] [PULL v2 14/15] pc: leave more space for BIOS allocations Michael S. Tsirkin
2014-09-18 18:19 ` [Qemu-devel] [PULL v2 15/15] tests: disable global props test for old glib Michael S. Tsirkin
2014-09-18 18:31 ` [Qemu-devel] [PULL v2 00/15] pci, pc, virtio, misc bugfixes Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411063757-29216-2-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=afaerber@suse.de \
    --cc=akong@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=marcel.a@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=tamlokveer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).