From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Don Slutz" <dslutz@verizon.com>,
"Anthony Liguori" <aliguori@amazon.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
=?UTF-8?q?Andreas=20F=C3=A4rber?= <afaerber@suse.de>
Subject: [Qemu-devel] [PULL v2 06/15] qdev: Rename qdev_prop_check_global() to qdev_prop_check_globals()
Date: Thu, 18 Sep 2014 21:10:23 +0300 [thread overview]
Message-ID: <1411063757-29216-7-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1411063757-29216-1-git-send-email-mst@redhat.com>
From: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/qdev-properties.h | 2 +-
hw/core/qdev-properties.c | 2 +-
tests/test-qdev-global-props.c | 2 +-
vl.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index 77fe3a1..ae56ee5 100644
--- a/include/hw/qdev-properties.h
+++ b/include/hw/qdev-properties.h
@@ -177,7 +177,7 @@ void qdev_prop_set_ptr(DeviceState *dev, const char *name, void *value);
void qdev_prop_register_global(GlobalProperty *prop);
void qdev_prop_register_global_list(GlobalProperty *props);
-int qdev_prop_check_global(void);
+int qdev_prop_check_globals(void);
void qdev_prop_set_globals(DeviceState *dev, Error **errp);
void qdev_prop_set_globals_for_type(DeviceState *dev, const char *typename,
Error **errp);
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index 3d12560..9075453 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -955,7 +955,7 @@ void qdev_prop_register_global_list(GlobalProperty *props)
}
}
-int qdev_prop_check_global(void)
+int qdev_prop_check_globals(void)
{
GlobalProperty *prop;
int ret = 0;
diff --git a/tests/test-qdev-global-props.c b/tests/test-qdev-global-props.c
index 26d8cb2..e1b008a 100644
--- a/tests/test-qdev-global-props.c
+++ b/tests/test-qdev-global-props.c
@@ -224,7 +224,7 @@ static void test_dynamic_globalprop_subprocess(void)
g_assert_cmpuint(mt->prop1, ==, 101);
g_assert_cmpuint(mt->prop2, ==, 102);
- all_used = qdev_prop_check_global();
+ all_used = qdev_prop_check_globals();
g_assert_cmpuint(all_used, ==, 1);
g_assert(!props[0].not_used);
g_assert(!props[1].not_used);
diff --git a/vl.c b/vl.c
index 9c9acf5..2aaa558 100644
--- a/vl.c
+++ b/vl.c
@@ -4541,7 +4541,7 @@ int main(int argc, char **argv, char **envp)
}
}
- qdev_prop_check_global();
+ qdev_prop_check_globals();
if (vmstate_dump_file) {
/* dump and exit */
dump_vmstate_json_to_file(vmstate_dump_file);
--
MST
next prev parent reply other threads:[~2014-09-18 18:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 18:10 [Qemu-devel] [PULL v2 00/15] pci, pc, virtio, misc bugfixes Michael S. Tsirkin
2014-09-18 18:10 ` [Qemu-devel] [PULL v2 02/15] test-qdev-global-props: Trivial comment fix Michael S. Tsirkin
2014-09-18 18:10 ` [Qemu-devel] [PULL v2 03/15] test-qdev-global-props: Run tests on subprocess Michael S. Tsirkin
2014-09-18 18:10 ` [Qemu-devel] [PULL v2 04/15] test-qdev-global-props: Initialize not_used=true for all props Michael S. Tsirkin
2014-09-18 18:10 ` [Qemu-devel] [PULL v2 05/15] test-qdev-global-props: Test handling of hotpluggable and non-device types Michael S. Tsirkin
2014-09-18 18:10 ` Michael S. Tsirkin [this message]
2014-09-18 18:18 ` [Qemu-devel] [PULL v2 01/15] hw/machine: Free old values of string properties Michael S. Tsirkin
2014-09-18 18:18 ` [Qemu-devel] [PULL v2 07/15] qdev: Move global validation to a single function Michael S. Tsirkin
2014-09-18 18:18 ` [Qemu-devel] [PULL v2 08/15] Revert "rng-egd: remove redundant free" Michael S. Tsirkin
2014-09-18 18:18 ` [Qemu-devel] [PULL v2 09/15] virtio-net: drop assert on vm stop Michael S. Tsirkin
2014-09-18 18:18 ` [Qemu-devel] [PULL v2 10/15] Revert "virtio: don't call device on !vm_running" Michael S. Tsirkin
2014-09-18 18:18 ` [Qemu-devel] [PULL v2 11/15] virtio-pci: enable bus master for old guests Michael S. Tsirkin
2014-09-18 18:18 ` [Qemu-devel] [PULL v2 12/15] vhost-user: fix VIRTIO_NET_F_MRG_RXBUF negotiation Michael S. Tsirkin
2014-09-18 18:19 ` [Qemu-devel] [PULL v2 13/15] virtio-pci: fix migration for pci bus master Michael S. Tsirkin
2014-09-18 18:19 ` [Qemu-devel] [PULL v2 14/15] pc: leave more space for BIOS allocations Michael S. Tsirkin
2014-09-18 18:19 ` [Qemu-devel] [PULL v2 15/15] tests: disable global props test for old glib Michael S. Tsirkin
2014-09-18 18:31 ` [Qemu-devel] [PULL v2 00/15] pci, pc, virtio, misc bugfixes Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411063757-29216-7-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=dslutz@verizon.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).