[Qemu-devel] [PATCH 14/15] qtest/ahci: Add human-readable command names

[John Snow <jsnow@redhat.com>]

Instead of using direct hex values, use SATA command mnemonics.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 tests/ahci-test.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index 63fc309..e3091b9 100644
--- a/tests/ahci-test.c
+++ b/tests/ahci-test.c
@@ -265,6 +265,14 @@
 #define CMDH_RES       (0x800)
 #define CMDH_PMP      (0xF000)
 
+/* ATA Commands */
+enum {
+    CMD_READ_DMA    = 0xC8,
+    CMD_WRITE_DMA   = 0xCA,
+    CMD_FLUSH_CACHE = 0xE7,
+    CMD_IDENTIFY    = 0xEC
+};
+
 /*** Structures ***/
 
 typedef struct AHCIPortState {
@@ -1673,7 +1681,7 @@ static void ahci_test_identify(AHCIState *ahci)
     g_assert(data_ptr);
 
     /* Construct the Command Table (FIS and PRDT) */
-    table_ptr = build_cmd_table(ahci, i, 512, 0xEC, data_ptr);
+    table_ptr = build_cmd_table(ahci, i, 512, CMD_IDENTIFY, data_ptr);
 
     /* Pick a command slot and link it to the command table we've built */
     cx = link_cmd_slot(ahci, i, table_ptr, CMDH_READ);
-- 
1.9.3