From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUlNf-0006MS-Mo for qemu-devel@nongnu.org; Thu, 18 Sep 2014 19:45:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUlNZ-0003ld-Ix for qemu-devel@nongnu.org; Thu, 18 Sep 2014 19:44:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUlNZ-0003jg-Cd for qemu-devel@nongnu.org; Thu, 18 Sep 2014 19:44:49 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8INihXn031478 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 18 Sep 2014 19:44:43 -0400 From: John Snow Date: Thu, 18 Sep 2014 19:43:38 -0400 Message-Id: <1411083819-9284-15-git-send-email-jsnow@redhat.com> In-Reply-To: <1411083819-9284-1-git-send-email-jsnow@redhat.com> References: <1411083819-9284-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PATCH 14/15] qtest/ahci: Add human-readable command names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, mst@redhat.com, armbru@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, John Snow Instead of using direct hex values, use SATA command mnemonics. Signed-off-by: John Snow --- tests/ahci-test.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index 63fc309..e3091b9 100644 --- a/tests/ahci-test.c +++ b/tests/ahci-test.c @@ -265,6 +265,14 @@ #define CMDH_RES (0x800) #define CMDH_PMP (0xF000) +/* ATA Commands */ +enum { + CMD_READ_DMA = 0xC8, + CMD_WRITE_DMA = 0xCA, + CMD_FLUSH_CACHE = 0xE7, + CMD_IDENTIFY = 0xEC +}; + /*** Structures ***/ typedef struct AHCIPortState { @@ -1673,7 +1681,7 @@ static void ahci_test_identify(AHCIState *ahci) g_assert(data_ptr); /* Construct the Command Table (FIS and PRDT) */ - table_ptr = build_cmd_table(ahci, i, 512, 0xEC, data_ptr); + table_ptr = build_cmd_table(ahci, i, 512, CMD_IDENTIFY, data_ptr); /* Pick a command slot and link it to the command table we've built */ cx = link_cmd_slot(ahci, i, table_ptr, CMDH_READ); -- 1.9.3