From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUrUm-00036K-9U for qemu-devel@nongnu.org; Fri, 19 Sep 2014 02:16:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUrUe-0008SZ-Ah for qemu-devel@nongnu.org; Fri, 19 Sep 2014 02:16:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUrUe-0008R8-3I for qemu-devel@nongnu.org; Fri, 19 Sep 2014 02:16:32 -0400 Message-ID: <1411107382.24750.6.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Fri, 19 Sep 2014 08:16:22 +0200 In-Reply-To: <541BA9A9.80300@ozlabs.ru> References: <1410512126-1580-1-git-send-email-aik@ozlabs.ru> <541BA9A9.80300@ozlabs.ru> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ohci: Convert fprint/DPRINTF/print to traces List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-devel@nongnu.org On Fr, 2014-09-19 at 13:57 +1000, Alexey Kardashevskiy wrote: > On 09/12/2014 06:55 PM, Alexey Kardashevskiy wrote: > > This converts many kinds of debug prints to traces. > > > > This implements packets logging to avoid unnecessary calculations if > > usb_ohci_td_pkt_short/usb_ohci_td_pkt_long is not enabled. > > > > This makes OHCI errors (such as "DMA error") invisible by default. > > > > Signed-off-by: Alexey Kardashevskiy > > --- > > > > > > First I wanted to hide "DMA error" and "OHCI die" but then decided do to > > some housecleaning + community work :) > > > > I could have chosen wrong names for some traces, please comment. Thanks! > > > Ping. > Too much? Too bad? :) Too much email in my inbox. Added to usb queue now. thanks, Gerd