From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUrvS-0007yz-7O for qemu-devel@nongnu.org; Fri, 19 Sep 2014 02:44:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUrvK-0006QQ-ME for qemu-devel@nongnu.org; Fri, 19 Sep 2014 02:44:14 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:39941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUrvI-0006Gd-Pj for qemu-devel@nongnu.org; Fri, 19 Sep 2014 02:44:06 -0400 From: zhanghailiang Date: Fri, 19 Sep 2014 14:43:02 +0800 Message-ID: <1411108984-4380-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH v6 0/2] dump: let dump_error return error reason to caller List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: zhanghailiang , luonengjun@huawei.com, peter.huangpeng@huawei.com, armbru@redhat.com, lcapitulino@redhat.com, lersek@redhat.com Hi, In original code, Function dump_error ignores its second parameter which contains error reason, it is better to return the error message to the caller. Here we use error_setg to return the error info to caller. And at the same time, we turn functions like write_elf64_note() to void, Because functions shouldn't return an error code _and_ an Error object. After this modification the code will be more clean. v5 -> v6 - Don't check *errp directly, if errp is NULL, there will be an error, Instead, check a local variable *local_err (Markus Armbruster) v4 -> v5: - Turn functions like write_elf64_note() to void (Luiz Capitulino) v3 -> v4: - Adjust the errp argument to the end - Remove trailing '.' in error messages v2 -> v3: - Drop the '\n' in the message when call dump_error(Eric Blake) v1 -> v2: - Return the error reason to the caller (Luiz Capitulino) zhanghailiang (2): dump: let dump_error return error info to caller dump: Don't return error code when return an Error object dump.c | 382 +++++++++++++++++++++++++++++++---------------------------------- 1 file changed, 182 insertions(+), 200 deletions(-) -- 1.7.12.4