qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: akong@redhat.com, lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH] qemu-socket: Polish errors for connect() and listen() failure
Date: Fri, 19 Sep 2014 09:27:04 +0200	[thread overview]
Message-ID: <1411111624-3064-1-git-send-email-armbru@redhat.com> (raw)

connect() doesn't "connect to socket", it connects a socket to an
address and, if it's of type SOCK_STREAM, initiates a connection.
Scratch "to".

listen() does "set socket to listening mode", but it sounds awkward.
Change to "listen on socket".

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 include/qapi/qmp/qerror.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h
index 902d1a7..774e75d 100644
--- a/include/qapi/qmp/qerror.h
+++ b/include/qapi/qmp/qerror.h
@@ -155,10 +155,10 @@ void qerror_report_err(Error *err);
     ERROR_CLASS_GENERIC_ERROR, "this feature or command is not currently supported"
 
 #define QERR_SOCKET_CONNECT_FAILED \
-    ERROR_CLASS_GENERIC_ERROR, "Failed to connect to socket"
+    ERROR_CLASS_GENERIC_ERROR, "Failed to connect socket"
 
 #define QERR_SOCKET_LISTEN_FAILED \
-    ERROR_CLASS_GENERIC_ERROR, "Failed to set socket to listening mode"
+    ERROR_CLASS_GENERIC_ERROR, "Failed to listen on socket"
 
 #define QERR_SOCKET_BIND_FAILED \
     ERROR_CLASS_GENERIC_ERROR, "Failed to bind socket"
-- 
1.9.3

             reply	other threads:[~2014-09-19  7:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-19  7:27 Markus Armbruster [this message]
2014-09-19  7:37 ` [Qemu-devel] [PATCH] qemu-socket: Polish errors for connect() and listen() failure Gonglei (Arei)
2014-09-19 17:05 ` Luiz Capitulino
2014-09-19 17:16   ` Markus Armbruster
2014-09-19 17:17     ` Luiz Capitulino
2014-09-26 17:19 ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411111624-3064-1-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=akong@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).