From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUsb8-000587-Kg for qemu-devel@nongnu.org; Fri, 19 Sep 2014 03:27:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUsb2-00087B-FP for qemu-devel@nongnu.org; Fri, 19 Sep 2014 03:27:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUsb2-00082n-5f for qemu-devel@nongnu.org; Fri, 19 Sep 2014 03:27:12 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8J7R6Jg019231 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 19 Sep 2014 03:27:06 -0400 From: Markus Armbruster Date: Fri, 19 Sep 2014 09:27:04 +0200 Message-Id: <1411111624-3064-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH] qemu-socket: Polish errors for connect() and listen() failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: akong@redhat.com, lcapitulino@redhat.com connect() doesn't "connect to socket", it connects a socket to an address and, if it's of type SOCK_STREAM, initiates a connection. Scratch "to". listen() does "set socket to listening mode", but it sounds awkward. Change to "listen on socket". Signed-off-by: Markus Armbruster --- include/qapi/qmp/qerror.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h index 902d1a7..774e75d 100644 --- a/include/qapi/qmp/qerror.h +++ b/include/qapi/qmp/qerror.h @@ -155,10 +155,10 @@ void qerror_report_err(Error *err); ERROR_CLASS_GENERIC_ERROR, "this feature or command is not currently supported" #define QERR_SOCKET_CONNECT_FAILED \ - ERROR_CLASS_GENERIC_ERROR, "Failed to connect to socket" + ERROR_CLASS_GENERIC_ERROR, "Failed to connect socket" #define QERR_SOCKET_LISTEN_FAILED \ - ERROR_CLASS_GENERIC_ERROR, "Failed to set socket to listening mode" + ERROR_CLASS_GENERIC_ERROR, "Failed to listen on socket" #define QERR_SOCKET_BIND_FAILED \ ERROR_CLASS_GENERIC_ERROR, "Failed to bind socket" -- 1.9.3