From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUtxc-0008RG-Ix for qemu-devel@nongnu.org; Fri, 19 Sep 2014 04:54:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUtxS-000403-Ur for qemu-devel@nongnu.org; Fri, 19 Sep 2014 04:54:36 -0400 Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:55804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUtxS-0003yi-O0 for qemu-devel@nongnu.org; Fri, 19 Sep 2014 04:54:26 -0400 Received: by mail-wi0-f177.google.com with SMTP id em10so2575398wid.16 for ; Fri, 19 Sep 2014 01:54:20 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Fri, 19 Sep 2014 10:54:09 +0200 Message-Id: <1411116849-18157-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1411116849-18157-1-git-send-email-pbonzini@redhat.com> References: <1411116849-18157-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] serial: check if backed by a physical serial port at realize time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com, pavel.dovgaluk@ispras.ru, batuzovk@ispras.ru Right now, s->poll_msl may linger at "0" value for an arbitrarily long time, until serial_update_msl is called for the first time. This is unnecessary, and will lead to the s->poll_msl field being unnecessarily migrated. We can call serial_update_msl immediately at realize time (via serial_reset) and be done with it. The memory-mapped UART was already doing that, but not the ISA and PCI variants. Regarding the delta bits, be consistent with what serial_reset does when the serial port is not backed by a physical serial port, and always clear them at reset time. Signed-off-by: Paolo Bonzini --- hw/char/serial.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/char/serial.c b/hw/char/serial.c index 4523ccb..e1dd0c9 100644 --- a/hw/char/serial.c +++ b/hw/char/serial.c @@ -650,6 +650,9 @@ static void serial_reset(void *opaque) s->thr_ipending = 0; s->last_break_enable = 0; qemu_irq_lower(s->irq); + + serial_update_msl(s); + s->msr &= ~UART_MSR_ANY_DELTA; } void serial_realize_core(SerialState *s, Error **errp) @@ -780,7 +783,5 @@ SerialState *serial_mm_init(MemoryRegion *address_space, memory_region_init_io(&s->io, NULL, &serial_mm_ops[end], s, "serial", 8 << it_shift); memory_region_add_subregion(address_space, base, &s->io); - - serial_update_msl(s); return s; } -- 2.1.0