qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: minyard@acm.org
To: qemu-devel@nongnu.org
Cc: bcketchum@gmail.com, mjg59@srcf.ucam.org, hwd@huawei.com,
	afaerber@suse.de, mst@redhat.com
Subject: [Qemu-devel] [PATCH 0/6] Add reconnect capability for client sockets
Date: Sun, 21 Sep 2014 18:04:18 -0500	[thread overview]
Message-ID: <1411340664-26912-1-git-send-email-minyard@acm.org> (raw)

I believe this fixes all the issues identified by the reviewers, and
also avoids leaking a few data items.

I also added some fixes for things that seemed sub-optimal.  The biggest
was that there was no way to tell from the monitor whether a socket was
connected or not.  Patch 4 sets the filename to "disconnected:<addr>" when
the socket disconnects, were <addr> is the address supplied by the user.

Changing "256' to a #define also seemed like a good idea.

It also seems like a good idea to me to print out the peer address of
a socket.  That's the last patch, so it can be easily dropped if this
is not wanted.

Thanks all,

-corey

             reply	other threads:[~2014-09-21 23:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-21 23:04 minyard [this message]
2014-09-21 23:04 ` [Qemu-devel] [PATCH 1/6] qemu-char: Make the filename size for a chardev a #define minyard
2014-09-22  7:46   ` Paolo Bonzini
2014-09-21 23:04 ` [Qemu-devel] [PATCH 2/6] qemu-char: Rework qemu_chr_open_socket() for reconnect minyard
2014-09-22  8:08   ` Paolo Bonzini
2014-09-21 23:04 ` [Qemu-devel] [PATCH 3/6] qemu-char: Move some items into TCPCharDriver minyard
2014-09-22  7:46   ` Paolo Bonzini
2014-09-21 23:04 ` [Qemu-devel] [PATCH 4/6] qemu-char: set socket filename to disconnected when not connected minyard
2014-09-22  8:06   ` Paolo Bonzini
2014-09-22 13:15     ` Corey Minyard
2014-09-22 13:25       ` Paolo Bonzini
2014-09-22 13:30         ` Corey Minyard
2014-09-22 13:39           ` Paolo Bonzini
2014-09-21 23:04 ` [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets minyard
2014-09-22  8:02   ` Paolo Bonzini
2014-09-22 20:24   ` Eric Blake
2014-09-22 20:36     ` Corey Minyard
2014-09-22 20:53       ` Eric Blake
2014-09-21 23:04 ` [Qemu-devel] [PATCH 6/6] qemu-char: Print the remote and local addresses for a socket minyard
2014-09-22  8:02   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411340664-26912-1-git-send-email-minyard@acm.org \
    --to=minyard@acm.org \
    --cc=afaerber@suse.de \
    --cc=bcketchum@gmail.com \
    --cc=hwd@huawei.com \
    --cc=mjg59@srcf.ucam.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).