From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Lieven <pl@kamp.de>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 3/3] trace-events: drop orphan iscsi trace events
Date: Mon, 22 Sep 2014 15:03:15 +0100 [thread overview]
Message-ID: <1411394595-15300-4-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1411394595-15300-1-git-send-email-stefanha@redhat.com>
iscsi_aio_write16_cb, iscsi_aio_writev, iscsi_aio_read16_cb, and
iscsi_aio_readv have not not been in use since commit
063c3378a9e3c25cc0afac3c72e4823d0621e352 ("block/iscsi: introduce
bdrv_co_{readv, writev, flush_to_disk}").
These were the only trace events in block/iscsi.c so drop the the
trace.h include.
Cc: Peter Lieven <pl@kamp.de>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/iscsi.c | 1 -
trace-events | 6 ------
2 files changed, 7 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 84bcae8..5fc3192 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -34,7 +34,6 @@
#include "qemu/bitops.h"
#include "qemu/bitmap.h"
#include "block/block_int.h"
-#include "trace.h"
#include "block/scsi.h"
#include "qemu/iov.h"
#include "sysemu/sysemu.h"
diff --git a/trace-events b/trace-events
index d69b503..467439b 100644
--- a/trace-events
+++ b/trace-events
@@ -876,12 +876,6 @@ escc_sunkbd_event_out(int ch) "Translated keycode 0x%2.2x"
escc_kbd_command(int val) "Command %d"
escc_sunmouse_event(int dx, int dy, int buttons_state) "dx=%d dy=%d buttons=%01x"
-# block/iscsi.c
-iscsi_aio_write16_cb(void *iscsi, int status, void *acb, int canceled) "iscsi %p status %d acb %p canceled %d"
-iscsi_aio_writev(void *iscsi, int64_t sector_num, int nb_sectors, void *opaque, void *acb) "iscsi %p sector_num %"PRId64" nb_sectors %d opaque %p acb %p"
-iscsi_aio_read16_cb(void *iscsi, int status, void *acb, int canceled) "iscsi %p status %d acb %p canceled %d"
-iscsi_aio_readv(void *iscsi, int64_t sector_num, int nb_sectors, void *opaque, void *acb) "iscsi %p sector_num %"PRId64" nb_sectors %d opaque %p acb %p"
-
# hw/scsi/esp.c
esp_error_fifo_overrun(void) "FIFO overrun"
esp_error_unhandled_command(uint32_t val) "unhandled command (%2.2x)"
--
1.9.3
next prev parent reply other threads:[~2014-09-22 14:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 14:03 [Qemu-devel] [PATCH 0/3] trace: drop orphan events from ./trace-events Stefan Hajnoczi
2014-09-22 14:03 ` [Qemu-devel] [PATCH 1/3] trace-events: drop orphan virtio_blk_data_plane_complete_request Stefan Hajnoczi
2014-09-22 14:03 ` [Qemu-devel] [PATCH 2/3] trace-events: drop orphan usb_mtp_data_out Stefan Hajnoczi
2014-09-22 14:03 ` Stefan Hajnoczi [this message]
2014-09-22 15:45 ` [Qemu-devel] [PATCH 0/3] trace: drop orphan events from ./trace-events Markus Armbruster
2014-09-23 10:11 ` Stefan Hajnoczi
2014-09-23 12:53 ` Markus Armbruster
2014-09-24 13:38 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411394595-15300-4-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).