From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWHy4-0003cR-HW for qemu-devel@nongnu.org; Tue, 23 Sep 2014 00:44:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWHxy-0003lr-Bd for qemu-devel@nongnu.org; Tue, 23 Sep 2014 00:44:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWHxy-0003lG-2t for qemu-devel@nongnu.org; Tue, 23 Sep 2014 00:44:42 -0400 Message-ID: <1411447428.3666.116.camel@localhost.localdomain> From: Marcel Apfelbaum Date: Tue, 23 Sep 2014 07:43:48 +0300 In-Reply-To: <1411418316-5169-1-git-send-email-lersek@redhat.com> References: <1411418316-5169-1-git-send-email-lersek@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] list supported machine types in well-defined order List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: peter.maydell@linaro.org, mst@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, afaerber@suse.de On Mon, 2014-09-22 at 22:38 +0200, Laszlo Ersek wrote: > The first patch introduces a generic comparator. This comparator should > cover all machine types at once that don't belong to machine type > "families". Hence, for example, the output it produces for > > qemu-system-aarch64 -M \? > > is meant to be final. (See examples in the patches.) > > The second patch files piix and q35 machine types into their respective > families. > > Paolo said we needed to care about "pseries, pc, q35", but I got no clue > about "pseries", so I didn't touch that. It shouldn't be hard for > someone who knows "pseries" to post a followup patch that covers it. > Until then, "pseries" machine types are listed in alphabetical order (no > families). > > Laszlo Ersek (2): > well-defined listing order for machine types > i386/pc: add piix and q35 machtypes to sorting families for -M \? > > include/hw/boards.h | 2 ++ > hw/i386/pc.c | 1 + > hw/i386/pc_piix.c | 1 + > hw/i386/pc_q35.c | 1 + > vl.c | 38 +++++++++++++++++++++++++++++++++++++- > 5 files changed, 42 insertions(+), 1 deletion(-) > Looks good to me. Reviewed-by: Marcel Apfelbaum Discussion only: 1. Adding the family field to machine options mechanism does leverage the machines hierarchy, but in another way and not through QOM. 2. The compare function looks exactly as I thought it would, my only difference was to take it a little further by let the family itself to sort its machines, but *is completely unnecessary* for this purpose. Your solution has a small footprint and I like it. Thanks, Marcel