From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWNZ8-0003Ks-Kp for qemu-devel@nongnu.org; Tue, 23 Sep 2014 06:43:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWNZ3-00036d-RB for qemu-devel@nongnu.org; Tue, 23 Sep 2014 06:43:26 -0400 Received: from szxga01-in.huawei.com ([119.145.14.64]:11734) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWNZ3-00032k-6k for qemu-devel@nongnu.org; Tue, 23 Sep 2014 06:43:21 -0400 From: zhanghailiang Date: Tue, 23 Sep 2014 18:42:24 +0800 Message-ID: <1411468944-10784-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH v2] vl: Adjust the place of calling mlockall to speedup VM's startup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: zhanghailiang , mst@redhat.com, hutao@cn.fujitsu.com, luonengjun@huawei.com, peter.huangpeng@huawei.com, imammedo@redhat.com If we configure mlock=on and memory policy=bind at the same time, It will consume lots of time for system to treat with memory, especially when call mbind behind mlockall. Adjust the place of calling mlockall, calling mbind before mlockall can remarkably reduce the time of VM's startup. Acked-by: Michael S. Tsirkin Signed-off-by: zhanghailiang --- v2: - Add Acked-by - change 'int' to 'bool' (Thanks Hu Tao) --- vl.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/vl.c b/vl.c index dc792fe..35e5de6 100644 --- a/vl.c +++ b/vl.c @@ -134,6 +134,7 @@ const char* keyboard_layout = NULL; ram_addr_t ram_size; const char *mem_path = NULL; int mem_prealloc = 0; /* force preallocation of physical target memory */ +bool enable_mlock = false; int nb_nics; NICInfo nd_table[MAX_NICS]; int autostart; @@ -1421,12 +1422,8 @@ static void smp_parse(QemuOpts *opts) } -static void configure_realtime(QemuOpts *opts) +static void realtime_init(void) { - bool enable_mlock; - - enable_mlock = qemu_opt_get_bool(opts, "mlock", true); - if (enable_mlock) { if (os_mlock() < 0) { fprintf(stderr, "qemu: locking memory failed\n"); @@ -3973,7 +3970,7 @@ int main(int argc, char **argv, char **envp) if (!opts) { exit(1); } - configure_realtime(opts); + enable_mlock = qemu_opt_get_bool(opts, "mlock", true); break; case QEMU_OPTION_msg: opts = qemu_opts_parse(qemu_find_opts("msg"), optarg, 0); @@ -4441,6 +4438,8 @@ int main(int argc, char **argv, char **envp) machine_class->init(current_machine); + realtime_init(); + audio_init(); cpu_synchronize_all_post_init(); -- 1.7.12.4