From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWPLk-0005ae-V2 for qemu-devel@nongnu.org; Tue, 23 Sep 2014 08:37:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWPLf-0000Sv-C5 for qemu-devel@nongnu.org; Tue, 23 Sep 2014 08:37:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWPLf-0000RO-61 for qemu-devel@nongnu.org; Tue, 23 Sep 2014 08:37:39 -0400 From: Gerd Hoffmann Date: Tue, 23 Sep 2014 14:13:13 +0200 Message-Id: <1411474417-9704-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1411474417-9704-1-git-send-email-kraxel@redhat.com> References: <1411474417-9704-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 02/26] usb-storage: fix possible memory leak and missing error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gonglei , Markus Armbruster , Gerd Hoffmann From: Gonglei When scsi_bus_legacy_add_drive() return NULL, meanwhile err will be not NULL, which will casue memory leak and missing error message. Cc: Markus Armbruster Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini Signed-off-by: Gerd Hoffmann --- hw/usb/dev-storage.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index eb75f6a..55ef684 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -624,6 +624,8 @@ static int usb_msd_initfn_storage(USBDevice *dev) s->conf.bootindex, dev->serial, &err); if (!scsi_dev) { + error_report("%s", error_get_pretty(err)); + error_free(err); return -1; } s->bus.qbus.allow_hotplug = 0; -- 1.8.3.1