From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWPFa-0005la-D3 for qemu-devel@nongnu.org; Tue, 23 Sep 2014 08:31:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWPFV-00078y-4c for qemu-devel@nongnu.org; Tue, 23 Sep 2014 08:31:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30739) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWPFU-00078F-Rh for qemu-devel@nongnu.org; Tue, 23 Sep 2014 08:31:17 -0400 From: Gerd Hoffmann Date: Tue, 23 Sep 2014 14:30:55 +0200 Message-Id: <1411475457-10942-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1411475457-10942-1-git-send-email-kraxel@redhat.com> References: <1411475457-10942-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 1/3] vga: Make fb endian a common state variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: David Gibson From: Benjamin Herrenschmidt And initialize it based on target endian Signed-off-by: Benjamin Herrenschmidt --- hw/display/vga.c | 32 +++++++++++++++++++------------- hw/display/vga_int.h | 1 + 2 files changed, 20 insertions(+), 13 deletions(-) diff --git a/hw/display/vga.c b/hw/display/vga.c index 9132e92..3f02984 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @@ -1461,16 +1461,11 @@ static void vga_draw_graphic(VGACommonState *s, int full_update) int disp_width, multi_scan, multi_run; uint8_t *d; uint32_t v, addr1, addr; - vga_draw_line_func *vga_draw_line; -#if defined(TARGET_WORDS_BIGENDIAN) - static const bool big_endian_fb = true; -#else - static const bool big_endian_fb = false; -#endif -#if defined(HOST_WORDS_BIGENDIAN) - static const bool byteswap = !big_endian_fb; + vga_draw_line_func *vga_draw_line = NULL; +#ifdef HOST_WORDS_BIGENDIAN + bool byteswap = !s->big_endian_fb; #else - static const bool byteswap = big_endian_fb; + bool byteswap = s->big_endian_fb; #endif full_update |= update_basic_params(s); @@ -1573,19 +1568,19 @@ static void vga_draw_graphic(VGACommonState *s, int full_update) bits = 8; break; case 15: - v = big_endian_fb ? VGA_DRAW_LINE15_BE : VGA_DRAW_LINE15_LE; + v = s->big_endian_fb ? VGA_DRAW_LINE15_BE : VGA_DRAW_LINE15_LE; bits = 15; break; case 16: - v = big_endian_fb ? VGA_DRAW_LINE16_BE : VGA_DRAW_LINE16_LE; + v = s->big_endian_fb ? VGA_DRAW_LINE16_BE : VGA_DRAW_LINE16_LE; bits = 15; break; case 24: - v = big_endian_fb ? VGA_DRAW_LINE24_BE : VGA_DRAW_LINE24_LE; + v = s->big_endian_fb ? VGA_DRAW_LINE24_BE : VGA_DRAW_LINE24_LE; bits = 24; break; case 32: - v = big_endian_fb ? VGA_DRAW_LINE32_BE : VGA_DRAW_LINE32_LE; + v = s->big_endian_fb ? VGA_DRAW_LINE32_BE : VGA_DRAW_LINE32_LE; bits = 32; break; } @@ -2129,6 +2124,17 @@ void vga_common_init(VGACommonState *s, Object *obj, bool global_vmstate) s->update_retrace_info = vga_precise_update_retrace_info; break; } + + /* + * Set default fb endian based on target, should probably be turned + * into a device attribute set by the machine/platform to remove + * all target endian dependencies from this file. + */ +#ifdef TARGET_WORDS_BIGENDIAN + s->big_endian_fb = true; +#else + s->big_endian_fb = false; +#endif vga_dirty_log_start(s); } diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h index 9073370..28d67cf 100644 --- a/hw/display/vga_int.h +++ b/hw/display/vga_int.h @@ -157,6 +157,7 @@ typedef struct VGACommonState { const GraphicHwOps *hw_ops; bool full_update_text; bool full_update_gfx; + bool big_endian_fb; /* hardware mouse cursor support */ uint32_t invalidated_y_table[VGA_MAX_HEIGHT / 32]; void (*cursor_invalidate)(struct VGACommonState *s); -- 1.8.3.1