qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com
Subject: [Qemu-devel] [PATCH 1/4] cleanup-trace-events.pl: Tighten search for trace event call
Date: Tue, 23 Sep 2014 14:53:28 +0200	[thread overview]
Message-ID: <1411476811-24251-2-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1411476811-24251-1-git-send-email-armbru@redhat.com>

The script can get fooled too easily.  For instance, it finds
trace_megasas_io_read_start when looking for trace_megasas_io_read,
and incorrectly concludes that event megasas_io_read is used.

Supply -w to git-grep to tighten the search.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 scripts/cleanup-trace-events.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/cleanup-trace-events.pl b/scripts/cleanup-trace-events.pl
index cffbf16..7e808ef 100755
--- a/scripts/cleanup-trace-events.pl
+++ b/scripts/cleanup-trace-events.pl
@@ -25,7 +25,7 @@ sub out {
 
 while (<>) {
     if (/^(disable )?([a-z_0-9]+)\(/) {
-        open GREP, '-|', 'git', 'grep', '-l', "trace_$2"
+        open GREP, '-|', 'git', 'grep', '-lw', "trace_$2"
             or die "run git grep: $!";
         my $fname;
         while ($fname = <GREP>) {
-- 
1.9.3

  reply	other threads:[~2014-09-23 12:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23 12:53 [Qemu-devel] [PATCH 0/4] trace-events: Clean up with cleanup-trace-events.pl again Markus Armbruster
2014-09-23 12:53 ` Markus Armbruster [this message]
2014-09-23 12:53 ` [Qemu-devel] [PATCH 2/4] trace-events: Drop unused megasas trace event Markus Armbruster
2014-09-23 12:53 ` [Qemu-devel] [PATCH 3/4] trace-events: Drop orphaned monitor " Markus Armbruster
2014-09-23 12:53 ` [Qemu-devel] [PATCH 4/4] trace-events: Fix comments pointing to source files Markus Armbruster
2014-09-24 13:42 ` [Qemu-devel] [PATCH 0/4] trace-events: Clean up with cleanup-trace-events.pl again Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411476811-24251-2-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).