From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWf8e-0005gp-SA for qemu-devel@nongnu.org; Wed, 24 Sep 2014 01:29:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWf8d-0004PL-NX for qemu-devel@nongnu.org; Wed, 24 Sep 2014 01:29:16 -0400 Received: from qemu.weilnetz.de ([2a03:4000:2:362::1]:58798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWf8d-0004Ou-Hc for qemu-devel@nongnu.org; Wed, 24 Sep 2014 01:29:15 -0400 From: Stefan Weil Date: Wed, 24 Sep 2014 07:20:02 +0200 Message-Id: <1411536002-14088-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH] virtio: Fix wrong type cast from pointer to long List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , Fam Zheng , qemu-devel@nongnu.org, Stefan Weil Compiler warning (w32, w64): include/hw/virtio/virtio_ring.h:142:26: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] When sizeof(long) < sizeof(void *), this is not only a warning but a real program error. Add also missing blanks in the same statement. Signed-off-by: Stefan Weil --- Peter, could you please apply this bug fix directly without pull request? Thanks Stefan include/hw/virtio/virtio_ring.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/virtio/virtio_ring.h b/include/hw/virtio/virtio_ring.h index 8f58bc9..0b42e6e 100644 --- a/include/hw/virtio/virtio_ring.h +++ b/include/hw/virtio/virtio_ring.h @@ -139,8 +139,8 @@ static inline void vring_init(struct vring *vr, unsigned int num, void *p, vr->num = num; vr->desc = p; vr->avail = p + num*sizeof(struct vring_desc); - vr->used = (void *)(((unsigned long)&vr->avail->ring[num] + sizeof(uint16_t) - + align-1) & ~(align - 1)); + vr->used = (void *)(((uintptr_t)&vr->avail->ring[num] + sizeof(uint16_t) + + align - 1) & ~(align - 1)); } static inline unsigned vring_size(unsigned int num, unsigned long align) -- 1.7.10.4