From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWfOf-0000U0-DQ for qemu-devel@nongnu.org; Wed, 24 Sep 2014 01:45:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWfOW-0008LU-Bc for qemu-devel@nongnu.org; Wed, 24 Sep 2014 01:45:49 -0400 Received: from mail-pa0-x235.google.com ([2607:f8b0:400e:c03::235]:56658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWfOV-0008K7-S7 for qemu-devel@nongnu.org; Wed, 24 Sep 2014 01:45:40 -0400 Received: by mail-pa0-f53.google.com with SMTP id hz1so7843284pad.26 for ; Tue, 23 Sep 2014 22:45:33 -0700 (PDT) From: Jun Li Date: Wed, 24 Sep 2014 13:45:27 +0800 Message-Id: <1411537527-16715-1-git-send-email-junmuzi@gmail.com> Subject: [Qemu-devel] [PATCH v2] Modify qemu_opt_rename to realize renaming all items in opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, Jun Li , juli@redhat.com, stefanha@redhat.com Add realization of rename all items in opts for qemu_opt_rename. e.g: When add bps twice in command line, need to rename all bps to throttling.bps-total. This patch solved following bug: Bug 1145586 - qemu-kvm will give strange hint when add bps twice for a drive ref:https://bugzilla.redhat.com/show_bug.cgi?id=1145586 Signed-off-by: Jun Li Reviewed-by: Eric Blake --- blockdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index b361fbb..ed95b76 100644 --- a/blockdev.c +++ b/blockdev.c @@ -536,8 +536,8 @@ static void qemu_opt_rename(QemuOpts *opts, const char *from, const char *to) { const char *value; - value = qemu_opt_get(opts, from); - if (value) { + /* rename all items in opts */ + while ((value = qemu_opt_get(opts, from))) { qemu_opt_set(opts, to, value); qemu_opt_unset(opts, from); } -- 1.9.3