qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: dmitry@daynix.com, borntraeger@de.ibm.com, mst@redhat.com,
	agraf@suse.de, cornelia.huck@de.ibm.com, kraxel@redhat.com,
	amit.shah@redhat.com, pbonzini@redhat.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH 00/30] complete conversion to hotplug-handler API
Date: Wed, 24 Sep 2014 11:47:49 +0000	[thread overview]
Message-ID: <1411559299-19042-1-git-send-email-imammedo@redhat.com> (raw)

Series unifies different hotplug mechanisms to a recent
hotplug-handler API and does shallow conversion of
devices that still use legacy qdev hotplug to it dropping
not used after that legacy hotplug path [29/30].
It also relaces SCSI's own way to do hotplug/unplug with
hotplug-handler callbacks leaving it the only method
perform hotplug tasks.
And the last patch [30/30] allows to unplug of BUS-less
devices using hotplug-handler API.

Converted devices are covered with new hotplug
unit-tests, except of:
 s390x-*: I have no idea how or means to test it, but code
          is close to virtio, so it's converted using
          virtio template
 pvscsi: is broken, so no means to test it

Git tree for testing:
  https://github.com/imammedo/qemu/commits/hp_ctrl_conversion_v1


Igor Mammedov (30):
  test: virtio-scsi: check if hot-plug/unplug works
  test: virtio-serial: check if hot-plug/unplug works
  test: virtio-rng: check if hot-plug/unplug works
  test: virtio-net: check if hot-plug/unplug works
  test: virtio-blk: check if hot-plug/unplug works
  test: usb: add port test to uhci unit test
  test: usb: generic usb device hotplug
  test: usb: usb-storage hotplug test
  access BusState.allow_hotplug using wraper qbus_is_hotpluggable()
  qdev: HotplugHandler: rename unplug callback to unplug_request
  qdev: HotplugHandler: provide unplug callback
  qdev: add simple/generic unplug callback for HotplugHandler
  qdev: hotplug: set handler only if HOTPLUG_HANDLER interface is
    supported
  target-i386: ICC bus: replace BusState.allow_hotplug with
    hotplug_handler
  virtio-pci: replace BusState.allow_hotplug with hotplug_handler
  virtio-serial: convert to hotplug-handler API
  virtio-mmio: drop useless bus->allow_hotplug = 0
  s390x: drop not used allow_hotplug in event-facility
  s390x: convert s390-virtio to hotplug handler API
  s390x: convert virtio-ccw to hotplug handler API
  scsi: make scsi_bus_new() assign hotplug controller
  scsi: convert pvscsi HBA to hotplug hander API
  scsi: convert virtio-scsi HBA to hotplug handler API
  scsi: cleanup not used anymore SCSIBusInfo{hotplug,hot_unplug} fields
  usb-bot: drop not needed "allow_hotplug = 0"
  usb-storage: make its storage SCSI bus hotpluggable explicitly
  usb-storage: drop not needed "allow_hotplug = 0"
  usb: convert to hotplug handler API
  qdev: drop legacy hotplug fields/methods
  qdev: HotplugHandler: add support for unplugging BUS-less devices

 hw/acpi/piix4.c                |  6 ++--
 hw/char/virtio-serial-bus.c    | 20 ++++++++---
 hw/core/hotplug.c              | 11 +++++++
 hw/core/qdev.c                 | 66 ++++++++++++++++++++++---------------
 hw/cpu/icc_bus.c               | 20 ++++++-----
 hw/i386/acpi-build.c           |  2 +-
 hw/isa/lpc_ich9.c              |  6 ++--
 hw/pci-bridge/pci_bridge_dev.c |  2 +-
 hw/pci/pci-hotplug-old.c       |  4 +--
 hw/pci/pcie.c                  |  4 +--
 hw/pci/pcie_port.c             |  2 +-
 hw/pci/shpc.c                  |  4 +--
 hw/s390x/event-facility.c      |  2 --
 hw/s390x/s390-virtio-bus.c     | 19 ++++++++---
 hw/s390x/virtio-ccw.c          | 24 +++++++++-----
 hw/scsi/scsi-bus.c             | 18 +---------
 hw/scsi/virtio-scsi.c          | 28 ++++++++++------
 hw/scsi/vmw_pvscsi.c           | 24 +++++++++-----
 hw/usb/bus.c                   |  3 +-
 hw/usb/dev-smartcard-reader.c  |  8 ++++-
 hw/usb/dev-storage.c           |  6 ++--
 hw/usb/hcd-ehci-pci.c          |  6 ++++
 hw/usb/hcd-ehci-sysbus.c       |  6 ++++
 hw/usb/hcd-ohci.c              | 12 +++++++
 hw/usb/hcd-uhci.c              |  6 ++++
 hw/usb/hcd-xhci.c              |  6 ++++
 hw/virtio/virtio-mmio.c        | 17 ++--------
 hw/virtio/virtio-pci.c         |  8 +++--
 include/hw/hotplug.h           | 18 ++++++++--
 include/hw/pci/pcie.h          |  4 +--
 include/hw/pci/shpc.h          |  4 +--
 include/hw/qdev-core.h         | 15 ++++++---
 include/hw/scsi/scsi.h         |  2 --
 qdev-monitor.c                 |  2 +-
 tests/Makefile                 |  9 ++---
 tests/test-usb-hcd-common.c    | 71 +++++++++++++++++++++++++++++++++++++++
 tests/test-usb-hcd-common.h    | 16 +++++++++
 tests/usb-hcd-ehci-test.c      | 50 +++++++++++-----------------
 tests/usb-hcd-ohci-test.c      | 10 ++++--
 tests/usb-hcd-uhci-test.c      | 64 +++++++++++++++++++++++++++++++++--
 tests/usb-hcd-xhci-test.c      | 11 +++++--
 tests/virtio-blk-test.c        | 75 +++++++++++++++++++++++++++++++++++-------
 tests/virtio-net-test.c        | 39 ++++++++++++++++++++++
 tests/virtio-rng-test.c        | 38 +++++++++++++++++++++
 tests/virtio-scsi-test.c       | 29 ++++++++++++++++
 tests/virtio-serial-test.c     | 27 +++++++++++++++
 46 files changed, 631 insertions(+), 193 deletions(-)
 create mode 100644 tests/test-usb-hcd-common.c
 create mode 100644 tests/test-usb-hcd-common.h

-- 
1.8.3.1

             reply	other threads:[~2014-09-24 11:48 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24 11:47 Igor Mammedov [this message]
2014-09-24 11:47 ` [Qemu-devel] [PATCH 01/30] test: virtio-scsi: check if hot-plug/unplug works Igor Mammedov
2014-09-24 12:32   ` Paolo Bonzini
2014-09-24 11:47 ` [Qemu-devel] [PATCH 02/30] test: virtio-serial: " Igor Mammedov
2014-09-24 12:33   ` Paolo Bonzini
2014-09-24 11:47 ` [Qemu-devel] [PATCH 03/30] test: virtio-rng: " Igor Mammedov
2014-09-24 12:35   ` Paolo Bonzini
2014-09-24 11:47 ` [Qemu-devel] [PATCH 04/30] test: virtio-net: " Igor Mammedov
2014-09-24 12:35   ` Paolo Bonzini
2014-09-24 11:47 ` [Qemu-devel] [PATCH 05/30] test: virtio-blk: " Igor Mammedov
2014-09-24 12:35   ` Paolo Bonzini
2014-09-24 11:47 ` [Qemu-devel] [PATCH 06/30] test: usb: add port test to uhci unit test Igor Mammedov
2014-09-24 12:30   ` Gerd Hoffmann
2014-09-24 14:06     ` Igor Mammedov
2014-09-24 11:47 ` [Qemu-devel] [PATCH 07/30] test: usb: generic usb device hotplug Igor Mammedov
2014-09-24 11:47 ` [Qemu-devel] [PATCH 08/30] test: usb: usb-storage hotplug test Igor Mammedov
2014-09-24 11:47 ` [Qemu-devel] [PATCH 09/30] access BusState.allow_hotplug using wraper qbus_is_hotpluggable() Igor Mammedov
2014-09-24 12:32   ` Paolo Bonzini
2014-09-25  2:00   ` Tang Chen
2014-09-25  8:05     ` Igor Mammedov
2014-09-24 11:47 ` [Qemu-devel] [PATCH 10/30] qdev: HotplugHandler: rename unplug callback to unplug_request Igor Mammedov
2014-09-24 12:16   ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 11/30] qdev: HotplugHandler: provide unplug callback Igor Mammedov
2014-09-24 12:17   ` Paolo Bonzini
2014-09-25  1:53   ` Tang Chen
2014-09-25  8:07     ` Igor Mammedov
2014-09-24 11:48 ` [Qemu-devel] [PATCH 12/30] qdev: add simple/generic unplug callback for HotplugHandler Igor Mammedov
2014-09-24 12:17   ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 13/30] qdev: hotplug: set handler only if HOTPLUG_HANDLER interface is supported Igor Mammedov
2014-09-24 12:19   ` Paolo Bonzini
2014-09-24 14:01     ` Igor Mammedov
2014-09-25  2:06   ` Tang Chen
2014-09-24 11:48 ` [Qemu-devel] [PATCH 14/30] target-i386: ICC bus: replace BusState.allow_hotplug with hotplug_handler Igor Mammedov
2014-09-24 12:22   ` Paolo Bonzini
2014-09-24 14:37     ` Igor Mammedov
2014-09-24 14:50       ` Paolo Bonzini
2014-09-24 15:30         ` Igor Mammedov
2014-09-24 15:34           ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 15/30] virtio-pci: " Igor Mammedov
2014-09-24 12:23   ` Paolo Bonzini
2014-09-24 14:51     ` Igor Mammedov
2014-09-24 14:53       ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 16/30] virtio-serial: convert to hotplug-handler API Igor Mammedov
2014-09-24 12:24   ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 17/30] virtio-mmio: drop useless bus->allow_hotplug = 0 Igor Mammedov
2014-09-24 12:24   ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 18/30] s390x: drop not used allow_hotplug in event-facility Igor Mammedov
2014-09-24 12:24   ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 19/30] s390x: convert s390-virtio to hotplug handler API Igor Mammedov
2014-09-24 11:48 ` [Qemu-devel] [PATCH 20/30] s390x: convert virtio-ccw " Igor Mammedov
2014-09-25 11:08   ` Cornelia Huck
2014-09-25 13:11     ` Igor Mammedov
2014-09-25 14:32       ` Cornelia Huck
2014-09-25 15:26         ` Igor Mammedov
2014-09-24 11:48 ` [Qemu-devel] [PATCH 21/30] scsi: make scsi_bus_new() assign hotplug controller Igor Mammedov
2014-09-24 12:11   ` Paolo Bonzini
2014-09-24 12:14   ` Paolo Bonzini
2014-09-24 15:00     ` Igor Mammedov
2014-09-24 11:48 ` [Qemu-devel] [PATCH 22/30] scsi: convert pvscsi HBA to hotplug hander API Igor Mammedov
2014-09-24 12:13   ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 23/30] scsi: convert virtio-scsi HBA to hotplug handler API Igor Mammedov
2014-09-24 12:15   ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 24/30] scsi: cleanup not used anymore SCSIBusInfo{hotplug, hot_unplug} fields Igor Mammedov
2014-09-24 12:12   ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 25/30] usb-bot: drop not needed "allow_hotplug = 0" Igor Mammedov
2014-09-24 12:27   ` Paolo Bonzini
2014-09-24 15:15     ` Igor Mammedov
2014-09-24 15:21       ` Paolo Bonzini
2014-09-25  8:01         ` Gerd Hoffmann
2014-09-25  8:12           ` Igor Mammedov
2014-09-25 14:10             ` Gerd Hoffmann
2014-09-25  7:59       ` Gerd Hoffmann
2014-09-24 11:48 ` [Qemu-devel] [PATCH 26/30] usb-storage: make its storage SCSI bus hotpluggable explicitly Igor Mammedov
2014-09-24 12:30   ` Paolo Bonzini
2014-09-24 12:56     ` Gerd Hoffmann
2014-09-24 12:50   ` Gerd Hoffmann
2014-09-24 15:22     ` Igor Mammedov
2014-09-25  7:52       ` Gerd Hoffmann
2014-09-24 11:48 ` [Qemu-devel] [PATCH 27/30] usb-storage: drop not needed "allow_hotplug = 0" Igor Mammedov
2014-09-24 12:31   ` Paolo Bonzini
2014-09-24 11:48 ` [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API Igor Mammedov
2014-09-24 13:00   ` Gerd Hoffmann
2014-09-24 13:04     ` Paolo Bonzini
2014-09-24 13:23       ` Gerd Hoffmann
2014-09-24 15:39         ` Igor Mammedov
2014-09-25  7:50           ` Gerd Hoffmann
2014-09-25 10:55             ` Igor Mammedov
2014-09-25 12:47               ` Paolo Bonzini
2014-09-25 13:22                 ` Igor Mammedov
2014-09-24 15:40     ` Igor Mammedov
2014-09-24 11:48 ` [Qemu-devel] [PATCH 29/30] qdev: drop legacy hotplug fields/methods Igor Mammedov
2014-09-24 12:04   ` Paolo Bonzini
2014-09-24 15:37     ` Igor Mammedov
2014-09-24 11:48 ` [Qemu-devel] [PATCH 30/30] qdev: HotplugHandler: add support for unplugging BUS-less devices Igor Mammedov
2014-09-24 12:00   ` Paolo Bonzini
2014-09-24 13:01 ` [Qemu-devel] [PATCH 00/30] complete conversion to hotplug-handler API Cornelia Huck
2014-09-24 14:20   ` Igor Mammedov
2014-09-24 15:01     ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411559299-19042-1-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=agraf@suse.de \
    --cc=amit.shah@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=dmitry@daynix.com \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).