From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWl4t-0005QY-Kh for qemu-devel@nongnu.org; Wed, 24 Sep 2014 07:49:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWl4n-0006Dw-Dq for qemu-devel@nongnu.org; Wed, 24 Sep 2014 07:49:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWl4n-0006D7-57 for qemu-devel@nongnu.org; Wed, 24 Sep 2014 07:49:41 -0400 From: Igor Mammedov Date: Wed, 24 Sep 2014 11:48:14 +0000 Message-Id: <1411559299-19042-26-git-send-email-imammedo@redhat.com> In-Reply-To: <1411559299-19042-1-git-send-email-imammedo@redhat.com> References: <1411559299-19042-1-git-send-email-imammedo@redhat.com> Subject: [Qemu-devel] [PATCH 25/30] usb-bot: drop not needed "allow_hotplug = 0" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: dmitry@daynix.com, borntraeger@de.ibm.com, mst@redhat.com, agraf@suse.de, cornelia.huck@de.ibm.com, kraxel@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, rth@twiddle.net usb-bot creates SCSI bus and immediately makes it non hotpluggable which makes not possible to add anything to it after machine is created. Taking in account that ubs-bot doesn't implement HOTPLUG_HANDLER interface, SCSI will be created as non hotpluggable, so there is not need to reset allow_hotplug field anymore. Signed-off-by: Igor Mammedov --- hw/usb/dev-storage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index bd7cc53..bfa71c7 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -653,7 +653,6 @@ static void usb_msd_realize_bot(USBDevice *dev, Error **errp) usb_desc_init(dev); scsi_bus_new(&s->bus, sizeof(s->bus), DEVICE(dev), &usb_msd_scsi_info_bot, NULL); - s->bus.qbus.allow_hotplug = 0; usb_msd_handle_reset(dev); } -- 1.8.3.1