From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWmYC-0005sz-OV for qemu-devel@nongnu.org; Wed, 24 Sep 2014 09:24:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWmY2-0006rN-4H for qemu-devel@nongnu.org; Wed, 24 Sep 2014 09:24:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45171) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWmY1-0006q4-SX for qemu-devel@nongnu.org; Wed, 24 Sep 2014 09:23:58 -0400 Message-ID: <1411565021.30748.9.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Wed, 24 Sep 2014 15:23:41 +0200 In-Reply-To: <5422C168.9030001@redhat.com> References: <1411559299-19042-1-git-send-email-imammedo@redhat.com> <1411559299-19042-29-git-send-email-imammedo@redhat.com> <1411563641.30748.7.camel@nilsson.home.kraxel.org> <5422C168.9030001@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 28/30] usb: convert to hotplug handler API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: dmitry@daynix.com, mst@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, amit.shah@redhat.com, Igor Mammedov , borntraeger@de.ibm.com, rth@twiddle.net Hi, > > Can't we do this in usb_bus_new instead of duplicating in every host > > adapter? > > So you would make TYPE_USB_BUS the hotplug handler itself, instead of > the controller? I was more thinking of just setting the callback in common code, but if we can attach the hotplug interface to the usb bus itself not the usb host adapters that would be even better. And it'll probably kill some headache for the companion controller case. cheers, Gerd