From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XX3xy-0001BQ-S4 for qemu-devel@nongnu.org; Thu, 25 Sep 2014 04:00:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XX3xs-0001i4-Mx for qemu-devel@nongnu.org; Thu, 25 Sep 2014 03:59:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XX3xs-0001h5-Eq for qemu-devel@nongnu.org; Thu, 25 Sep 2014 03:59:48 -0400 Message-ID: <1411631971.7154.4.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Thu, 25 Sep 2014 09:59:31 +0200 In-Reply-To: <20140924171504.7d1e27f9@nial.usersys.redhat.com> References: <1411559299-19042-1-git-send-email-imammedo@redhat.com> <1411559299-19042-26-git-send-email-imammedo@redhat.com> <5422B89B.7070805@redhat.com> <20140924171504.7d1e27f9@nial.usersys.redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 25/30] usb-bot: drop not needed "allow_hotplug = 0" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: dmitry@daynix.com, mst@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, amit.shah@redhat.com, Paolo Bonzini , borntraeger@de.ibm.com, rth@twiddle.net Hi, > But there is room for improvement here, > it it's possible to error out even earlier if usb-bot would be marked > as not hotpluggable device and add to qdev_device_add() check if > device is hotpluggable even before it's created. usb-bot not being hot-pluggable is a consequence of the fact that we can only hotplug single devices in qemu today. usb-bot without scsi devices hooked up is useless. Plugging in usb-bot first and plugging in disks later doesn't work (well, could sort-of work when you plug them fast, but you are racing with the guest initializing the device then). With some way to first compose the whole thing (usb-bot + disks), then plug-in as whole usb-bot hotplugging would work though. cheers, Gerd