From: "Alex Bennée" <alex.bennee@linaro.org>
To: aik@ozlabs.ru
Cc: qemu-devel@nongnu.org, kraxel@redhat.com, stefanha@redhat.com,
mohamad.gebai@gmail.com, "Alex Bennée" <alex.bennee@linaro.org>,
vilanova@ac.upc.edu
Subject: [Qemu-devel] [PATCH] ohci: drop computed flags from trace events
Date: Thu, 25 Sep 2014 10:38:44 +0100 [thread overview]
Message-ID: <1411637924-6981-1-git-send-email-alex.bennee@linaro.org> (raw)
In-Reply-To: <1411604219-15029-1-git-send-email-aik@ozlabs.ru>
This exceeded the trace argument limit for LTTNG UST and wasn't really
needed as the flags value is stored anyway. Dropping this fixes the
compile failure for UST. It can probably be merged with the previous
trace shortening patch.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
hw/usb/hcd-ohci.c | 3 +--
trace-events | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index 8d3c9cc..9a84eb6 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
@@ -724,8 +724,7 @@ static int ohci_service_iso_td(OHCIState *ohci, struct ohci_ed *ed,
ed->head & OHCI_DPTR_MASK, ed->tail & OHCI_DPTR_MASK,
iso_td.flags, iso_td.bp, iso_td.next, iso_td.be,
ohci->frame_number, starting_frame,
- frame_count, relative_frame_number,
- OHCI_BM(iso_td.flags, TD_DI), OHCI_BM(iso_td.flags, TD_CC));
+ frame_count, relative_frame_number);
trace_usb_ohci_iso_td_head_offset(
iso_td.offset[0], iso_td.offset[1],
iso_td.offset[2], iso_td.offset[3],
diff --git a/trace-events b/trace-events
index a3c1aac..ac962be 100644
--- a/trace-events
+++ b/trace-events
@@ -297,7 +297,7 @@ usb_port_release(int bus, const char *port) "bus %d, port %s"
# hw/usb/hcd-ohci.c
usb_ohci_iso_td_read_failed(uint32_t addr) "ISO_TD read error at %x"
-usb_ohci_iso_td_head(uint32_t head, uint32_t tail, uint32_t flags, uint32_t bp, uint32_t next, uint32_t be, uint32_t framenum, uint32_t startframe, uint32_t framecount, int rel_frame_num, uint32_t bm_di, uint32_t td_cc) "ISO_TD ED head 0x%.8x tailp 0x%.8x\n0x%.8x 0x%.8x 0x%.8x 0x%.8x\nframe_number 0x%.8x starting_frame 0x%.8x\nframe_count 0x%.8x relative %d\ndi 0x%.8x cc 0x%.8x"
+usb_ohci_iso_td_head(uint32_t head, uint32_t tail, uint32_t flags, uint32_t bp, uint32_t next, uint32_t be, uint32_t framenum, uint32_t startframe, uint32_t framecount, int rel_frame_num) "ISO_TD ED head 0x%.8x tailp 0x%.8x\n0x%.8x 0x%.8x 0x%.8x 0x%.8x\nframe_number 0x%.8x starting_frame 0x%.8x\nframe_count 0x%.8x relative %d"
usb_ohci_iso_td_head_offset(uint32_t o0, uint32_t o1, uint32_t o2, uint32_t o3, uint32_t o4, uint32_t o5, uint32_t o6, uint32_t o7) "0x%.8x 0x%.8x 0x%.8x 0x%.8x 0x%.8x 0x%.8x 0x%.8x 0x%.8x"
usb_ohci_iso_td_relative_frame_number_neg(int rel) "ISO_TD R=%d < 0"
usb_ohci_iso_td_relative_frame_number_big(int rel, int count) "ISO_TD R=%d > FC=%d"
--
2.1.0
next prev parent reply other threads:[~2014-09-25 9:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 0:16 [Qemu-devel] [PATCH] ohci: Split long traces to smaller ones Alexey Kardashevskiy
2014-09-25 8:09 ` Gerd Hoffmann
2014-09-25 9:38 ` Alexey Kardashevskiy
2014-09-25 14:08 ` Gerd Hoffmann
2014-09-25 9:18 ` Alex Bennée
2014-09-25 9:38 ` Alex Bennée [this message]
2014-09-25 10:50 ` [Qemu-devel] [PATCH] ohci: drop computed flags from trace events Stefan Hajnoczi
2014-09-26 8:51 ` Stefan Hajnoczi
2014-09-26 8:51 ` [Qemu-devel] [PATCH] ohci: Split long traces to smaller ones Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411637924-6981-1-git-send-email-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aik@ozlabs.ru \
--cc=kraxel@redhat.com \
--cc=mohamad.gebai@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).