From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXFVO-00009j-6p for qemu-devel@nongnu.org; Thu, 25 Sep 2014 16:19:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXFVH-0004u3-S9 for qemu-devel@nongnu.org; Thu, 25 Sep 2014 16:19:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXFVH-0004tK-LY for qemu-devel@nongnu.org; Thu, 25 Sep 2014 16:19:03 -0400 From: Eduardo Habkost Date: Thu, 25 Sep 2014 17:18:24 -0300 Message-Id: <1411676309-20218-6-git-send-email-ehabkost@redhat.com> In-Reply-To: <1411676309-20218-1-git-send-email-ehabkost@redhat.com> References: <1411676309-20218-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [RFC 05/10] tests: Support target-specific unit tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Igor Mammedov , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Paolo Bonzini To make unit tests that depend on target-specific files, use check-unit--y and test-obj--y. Note that the qtest test cases were per-*arch* (e.g. i386, mips, ppc), not per-*target* (e.g. i386-softmmu, x86_64-linux-user), because they implicitly apply only to the -softmmu targets. Target-specific unit tests, on the other hand, may apply to any target (e.g. they may test *-softmmu and/or *-user code). To clarify this, $(TARGETS) was renamed to $(QTEST_ARCHES). Signed-off-by: Eduardo Habkost --- tests/Makefile | 31 +++++++++++++++++++++++-------- 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index 483ba61..95566d9 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -356,12 +356,27 @@ ifeq ($(CONFIG_POSIX),y) LIBS += -lutil endif + +SOFTMMU_TARGETS=$(filter %-softmmu,$(TARGET_DIRS)) +SOFTMMU_ARCHES=$(patsubst %-softmmu,%, $(SOFTMMU_TARGETS)) + +# unit test rules: + +# target-specific tests/objs: + +test-obj-y += $(foreach TARGET,$(TARGET_DIRS), $(test-obj-$(TARGET)-y)) +check-unit-y += $(foreach TARGET,$(TARGET_DIRS), $(check-unit-$(TARGET)-y)) + +$(foreach TARGET,$(TARGET_DIRS),$(eval include $(TARGET)/config-target.mak) \ + $(eval $(test-obj-$(TARGET)-y): QEMU_CFLAGS += -I$(TARGET) -I$(SRC_PATH)/target-$(TARGET_BASE_ARCH) -DNEED_CPU_H)) + +$(test-obj-y): QEMU_INCLUDES += -Itests + # QTest rules -TARGETS=$(patsubst %-softmmu,%, $(filter %-softmmu,$(TARGET_DIRS))) ifeq ($(CONFIG_POSIX),y) -QTEST_TARGETS=$(foreach TARGET,$(TARGETS), $(if $(check-qtest-$(TARGET)-y), $(TARGET),)) -check-qtest-y=$(foreach TARGET,$(TARGETS), $(check-qtest-$(TARGET)-y)) +QTEST_ARCHES=$(foreach ARCH,$(SOFTMMU_ARCHES), $(if $(check-qtest-$(ARCH)-y), $(ARCH),)) +check-qtest-y=$(foreach ARCH,$(QTEST_ARCHES), $(check-qtest-$(ARCH)-y)) endif qtest-obj-y = tests/libqtest.o libqemuutil.a libqemustub.a @@ -393,8 +408,8 @@ GCOV_OPTIONS = -n $(if $(V),-f,) # gtester tests, possibly with verbose output -.PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS)) -$(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: $(check-qtest-y) +.PHONY: $(patsubst %, check-qtest-%, $(QTEST_ARCHES)) +$(patsubst %, check-qtest-%, $(QTEST_ARCHES)): check-qtest-%: $(check-qtest-y) $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \ MALLOC_PERTURB_=$${MALLOC_PERTURB_:-$$((RANDOM % 255 + 1))} \ @@ -417,7 +432,7 @@ $(patsubst %, check-%, $(check-unit-y)): check-%: % # gtester tests with XML output -$(patsubst %, check-report-qtest-%.xml, $(QTEST_TARGETS)): check-report-qtest-%.xml: $(check-qtest-y) +$(patsubst %, check-report-qtest-%.xml, $(QTEST_ARCHES)): check-report-qtest-%.xml: $(check-qtest-y) $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \ gtester -q $(GTESTER_OPTIONS) -o $@ -m=$(SPEED) $(check-qtest-$*-y),"GTESTER $@") @@ -426,7 +441,7 @@ check-report-unit.xml: $(check-unit-y) # Reports and overall runs -check-report.xml: $(patsubst %,check-report-qtest-%.xml, $(QTEST_TARGETS)) check-report-unit.xml +check-report.xml: $(patsubst %,check-report-qtest-%.xml, $(QTEST_ARCHES)) check-report-unit.xml $(call quiet-command,$(SRC_PATH)/scripts/gtester-cat $^ > $@, " GEN $@") check-report.html: check-report.xml @@ -460,7 +475,7 @@ $(patsubst %, check-%, $(check-qapi-schema-y)): check-%.json: $(SRC_PATH)/%.json .PHONY: check-qapi-schema check-qtest check-unit check check-clean check-qapi-schema: $(patsubst %,check-%, $(check-qapi-schema-y)) -check-qtest: $(patsubst %,check-qtest-%, $(QTEST_TARGETS)) +check-qtest: $(patsubst %,check-qtest-%, $(QTEST_ARCHES)) check-unit: $(patsubst %,check-%, $(check-unit-y)) check-block: $(patsubst %,check-%, $(check-block-y)) check: check-qapi-schema check-unit check-qtest -- 1.9.3