Re: [Qemu-devel] [PATCH 3/8] vga: Separate LE and BE conversion functions

[Gerd Hoffmann <kraxel@redhat.com>]

> > > @@ -1572,19 +1585,19 @@ static void vga_draw_graphic(VGACommonState *s, int full_update)
> >              bits = 8;
> >              break;
> >          case 15:
> > -            v = VGA_DRAW_LINE15;
> > -            bits = 16;
> > +            v = big_endian_fb ? VGA_DRAW_LINE15_BE : VGA_DRAW_LINE15_LE;
> > +            bits = 15;
> >              break;
> >          case 16:
> > -            v = VGA_DRAW_LINE16;
> > -            bits = 16;
> > +            v = big_endian_fb ? VGA_DRAW_LINE16_BE : VGA_DRAW_LINE16_LE;
> > +            bits = 15;
> 
> Is the change from bits=16 to bits=15 correct in this case?

No, it isn't.  Thanks for catching this, I'll go fix it up.

cheers,
  Gerd