From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXPoB-0003iM-4e for qemu-devel@nongnu.org; Fri, 26 Sep 2014 03:19:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXPo5-0007bE-1T for qemu-devel@nongnu.org; Fri, 26 Sep 2014 03:19:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXPo4-0007ZX-Fu for qemu-devel@nongnu.org; Fri, 26 Sep 2014 03:19:08 -0400 Message-ID: <1411712703.865.0.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Fri, 26 Sep 2014 08:25:03 +0200 In-Reply-To: <20140926041648.GJ24332@voom.redhat.com> References: <1411397096-31566-1-git-send-email-kraxel@redhat.com> <1411397096-31566-4-git-send-email-kraxel@redhat.com> <20140926041648.GJ24332@voom.redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/8] vga: Separate LE and BE conversion functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-devel@nongnu.org > > > @@ -1572,19 +1585,19 @@ static void vga_draw_graphic(VGACommonState *s, int full_update) > > bits = 8; > > break; > > case 15: > > - v = VGA_DRAW_LINE15; > > - bits = 16; > > + v = big_endian_fb ? VGA_DRAW_LINE15_BE : VGA_DRAW_LINE15_LE; > > + bits = 15; > > break; > > case 16: > > - v = VGA_DRAW_LINE16; > > - bits = 16; > > + v = big_endian_fb ? VGA_DRAW_LINE16_BE : VGA_DRAW_LINE16_LE; > > + bits = 15; > > Is the change from bits=16 to bits=15 correct in this case? No, it isn't. Thanks for catching this, I'll go fix it up. cheers, Gerd