From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXRr6-0002n3-0K for qemu-devel@nongnu.org; Fri, 26 Sep 2014 05:30:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXRqz-00083R-OP for qemu-devel@nongnu.org; Fri, 26 Sep 2014 05:30:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22424) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXRqz-00082x-I2 for qemu-devel@nongnu.org; Fri, 26 Sep 2014 05:30:17 -0400 From: Igor Mammedov Date: Fri, 26 Sep 2014 09:28:36 +0000 Message-Id: <1411723721-20484-32-git-send-email-imammedo@redhat.com> In-Reply-To: <1411723721-20484-1-git-send-email-imammedo@redhat.com> References: <1411723721-20484-1-git-send-email-imammedo@redhat.com> Subject: [Qemu-devel] [PATCH v2 31/36] usb-bot: drop not needed "allow_hotplug = 0" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: cornelia.huck@de.ibm.com, mst@redhat.com, amit.shah@redhat.com, agraf@suse.de, borntraeger@de.ibm.com, kraxel@redhat.com, dmitry@daynix.com, pbonzini@redhat.com, rth@twiddle.net Drop useless hack that disables hotplug on bus by setting "allow_hotplug = 0". Even if bus is hotpluggable, It won't be possible to add another SCSI device to bus since its realize will fail early with error "no free target" in scsi_qdev_realize() method. Signed-off-by: Igor Mammedov --- hw/usb/dev-storage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index a207507..bccaa3f 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -653,7 +653,6 @@ static void usb_msd_realize_bot(USBDevice *dev, Error **errp) usb_desc_init(dev); scsi_bus_new(&s->bus, sizeof(s->bus), DEVICE(dev), &usb_msd_scsi_info_bot, NULL); - s->bus.qbus.allow_hotplug = 0; usb_msd_handle_reset(dev); } -- 1.8.3.1