From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXRrA-0002vJ-Hn for qemu-devel@nongnu.org; Fri, 26 Sep 2014 05:30:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXRr2-00083n-81 for qemu-devel@nongnu.org; Fri, 26 Sep 2014 05:30:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXRr2-000835-0W for qemu-devel@nongnu.org; Fri, 26 Sep 2014 05:30:20 -0400 From: Igor Mammedov Date: Fri, 26 Sep 2014 09:28:37 +0000 Message-Id: <1411723721-20484-33-git-send-email-imammedo@redhat.com> In-Reply-To: <1411723721-20484-1-git-send-email-imammedo@redhat.com> References: <1411723721-20484-1-git-send-email-imammedo@redhat.com> Subject: [Qemu-devel] [PATCH v2 32/36] usb-storage: drop not needed "allow_hotplug = 0" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: cornelia.huck@de.ibm.com, mst@redhat.com, amit.shah@redhat.com, agraf@suse.de, borntraeger@de.ibm.com, kraxel@redhat.com, dmitry@daynix.com, pbonzini@redhat.com, rth@twiddle.net Drop useless hack that disables hotplug on bus, after backend storage was added to it, by setting "allow_hotplug = 0". Even if bus is hotpluggable, It won't be possible to add another SCSI device to bus since its realize will fail early with error "no free target" in scsi_qdev_realize() method. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini --- hw/usb/dev-storage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index bccaa3f..b005783 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -632,7 +632,6 @@ static void usb_msd_realize_storage(USBDevice *dev, Error **errp) error_propagate(errp, err); return; } - s->bus.qbus.allow_hotplug = 0; usb_msd_handle_reset(dev); if (bdrv_key_required(bs)) { -- 1.8.3.1