From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXTdX-00056I-6R for qemu-devel@nongnu.org; Fri, 26 Sep 2014 07:24:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXTdQ-00049V-Eb for qemu-devel@nongnu.org; Fri, 26 Sep 2014 07:24:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57100) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXTdQ-00047u-6i for qemu-devel@nongnu.org; Fri, 26 Sep 2014 07:24:24 -0400 From: Stefan Hajnoczi Date: Fri, 26 Sep 2014 11:59:28 +0100 Message-Id: <1411729177-5222-8-git-send-email-stefanha@redhat.com> In-Reply-To: <1411729177-5222-1-git-send-email-stefanha@redhat.com> References: <1411729177-5222-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 07/16] trace-events: drop orphan iscsi trace events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Peter Lieven , Stefan Hajnoczi iscsi_aio_write16_cb, iscsi_aio_writev, iscsi_aio_read16_cb, and iscsi_aio_readv have not not been in use since commit 063c3378a9e3c25cc0afac3c72e4823d0621e352 ("block/iscsi: introduce bdrv_co_{readv, writev, flush_to_disk}"). These were the only trace events in block/iscsi.c so drop the the trace.h include. Cc: Peter Lieven Signed-off-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Message-id: 1411394595-15300-4-git-send-email-stefanha@redhat.com --- block/iscsi.c | 1 - trace-events | 6 ------ 2 files changed, 7 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 3c1b416..5c72ffe 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -34,7 +34,6 @@ #include "qemu/bitops.h" #include "qemu/bitmap.h" #include "block/block_int.h" -#include "trace.h" #include "block/scsi.h" #include "qemu/iov.h" #include "sysemu/sysemu.h" diff --git a/trace-events b/trace-events index d70b75f..f17ec0d 100644 --- a/trace-events +++ b/trace-events @@ -932,12 +932,6 @@ escc_sunkbd_event_out(int ch) "Translated keycode 0x%2.2x" escc_kbd_command(int val) "Command %d" escc_sunmouse_event(int dx, int dy, int buttons_state) "dx=%d dy=%d buttons=%01x" -# block/iscsi.c -iscsi_aio_write16_cb(void *iscsi, int status, void *acb, int canceled) "iscsi %p status %d acb %p canceled %d" -iscsi_aio_writev(void *iscsi, int64_t sector_num, int nb_sectors, void *opaque, void *acb) "iscsi %p sector_num %"PRId64" nb_sectors %d opaque %p acb %p" -iscsi_aio_read16_cb(void *iscsi, int status, void *acb, int canceled) "iscsi %p status %d acb %p canceled %d" -iscsi_aio_readv(void *iscsi, int64_t sector_num, int nb_sectors, void *opaque, void *acb) "iscsi %p sector_num %"PRId64" nb_sectors %d opaque %p acb %p" - # hw/scsi/esp.c esp_error_fifo_overrun(void) "FIFO overrun" esp_error_unhandled_command(uint32_t val) "unhandled command (%2.2x)" -- 1.9.3