From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Subject: [Qemu-devel] [PULL 11/11] kvm/valgrind: don't mark memory as initialized
Date: Fri, 26 Sep 2014 16:38:10 +0200 [thread overview]
Message-ID: <1411742290-2940-12-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1411742290-2940-1-git-send-email-pbonzini@redhat.com>
From: Christian Borntraeger <borntraeger@de.ibm.com>
since commit 7dda5dc82a77 ("migration: initialize RAM to zero") the
guest memory is defined zero. No need to call valgrind on guest memory.
This reverts commit 62fe83318d2f ("qemu: Use valgrind annotations to
mark kvm guest memory as defined") thus speeding up kvm start if
<includedir>/valgrind/valgrind.h is available.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 3 +--
kvm-all.c | 7 -------
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/configure b/configure
index 1a9daa5..f9c0926 100755
--- a/configure
+++ b/configure
@@ -3961,12 +3961,11 @@ else
fi
########################################
-# check if we have valgrind/valgrind.h and valgrind/memcheck.h
+# check if we have valgrind/valgrind.h
valgrind_h=no
cat > $TMPC << EOF
#include <valgrind/valgrind.h>
-#include <valgrind/memcheck.h>
int main(void) {
return 0;
}
diff --git a/kvm-all.c b/kvm-all.c
index 6c6586f..4afcd05 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -44,10 +44,6 @@
#include <sys/eventfd.h>
#endif
-#ifdef CONFIG_VALGRIND_H
-#include <valgrind/memcheck.h>
-#endif
-
/* KVM uses PAGE_SIZE in its definition of COALESCED_MMIO_MAX */
#define PAGE_SIZE TARGET_PAGE_SIZE
@@ -1959,9 +1955,6 @@ int kvm_has_intx_set_mask(void)
void kvm_setup_guest_memory(void *start, size_t size)
{
-#ifdef CONFIG_VALGRIND_H
- VALGRIND_MAKE_MEM_DEFINED(start, size);
-#endif
if (!kvm_has_sync_mmu()) {
int ret = qemu_madvise(start, size, QEMU_MADV_DONTFORK);
--
2.1.0
next prev parent reply other threads:[~2014-09-26 14:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 14:37 [Qemu-devel] [PULL 00/11] KVM (and more) patches for 2014-09-26 Paolo Bonzini
2014-09-26 14:38 ` [Qemu-devel] [PULL 01/11] pit: fix pit interrupt can't inject into vm after migration Paolo Bonzini
2014-09-26 14:38 ` [Qemu-devel] [PULL 02/11] Introduce cpu_clean_all_dirty Paolo Bonzini
2014-09-26 14:38 ` [Qemu-devel] [PULL 03/11] kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation Paolo Bonzini
2014-09-26 14:38 ` [Qemu-devel] [PULL 04/11] kvmclock: Ensure time in migration never goes backward Paolo Bonzini
2014-09-26 14:38 ` [Qemu-devel] [PULL 05/11] hw/dma/i8257: Silence phony error message Paolo Bonzini
2014-09-26 14:38 ` [Qemu-devel] [PULL 06/11] target-i386: update fp status fix Paolo Bonzini
2014-09-26 14:38 ` [Qemu-devel] [PULL 07/11] serial: reset state at startup Paolo Bonzini
2014-09-26 14:38 ` [Qemu-devel] [PULL 08/11] serial: check if backed by a physical serial port at realize time Paolo Bonzini
2014-09-26 14:38 ` [Qemu-devel] [PULL 09/11] kvmvapic: fix migration when VM paused and when not running Windows Paolo Bonzini
2014-09-26 14:38 ` [Qemu-devel] [PULL 10/11] po: fix conflict with %.mo rule in rules.mak Paolo Bonzini
2014-09-26 14:38 ` Paolo Bonzini [this message]
2014-09-26 17:16 ` [Qemu-devel] [PULL 00/11] KVM (and more) patches for 2014-09-26 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411742290-2940-12-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).