From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47092) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXWk8-0003Hv-IH for qemu-devel@nongnu.org; Fri, 26 Sep 2014 10:43:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXWjz-0003Ah-9i for qemu-devel@nongnu.org; Fri, 26 Sep 2014 10:43:32 -0400 Received: from mail-qc0-x22c.google.com ([2607:f8b0:400d:c01::22c]:38863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXWjz-0003AE-4m for qemu-devel@nongnu.org; Fri, 26 Sep 2014 10:43:23 -0400 Received: by mail-qc0-f172.google.com with SMTP id c9so7062793qcz.31 for ; Fri, 26 Sep 2014 07:43:17 -0700 (PDT) Message-ID: <1411742593.21562.2.camel@gmail.com> From: Jan Vesely Date: Fri, 26 Sep 2014 10:43:13 -0400 In-Reply-To: <1411715162.865.4.camel@nilsson.home.kraxel.org> References: <1411681094-8474-1-git-send-email-jano.vesely@gmail.com> <1411681094-8474-2-git-send-email-jano.vesely@gmail.com> <1411715162.865.4.camel@nilsson.home.kraxel.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-lz2A9sygcnTvFOLtFKYF" Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v4 2/3] usb-hid: Add high speed mouse configuration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: QEMU --=-lz2A9sygcnTvFOLtFKYF Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2014-09-26 at 09:06 +0200, Gerd Hoffmann wrote: > On Do, 2014-09-25 at 17:38 -0400, Jan Vesely wrote: > > v2: add usb_mouse_properties > > use macros for bmAttributes > > v3: rebase > > v4: rebase >=20 > patch looks good, the only thing missing is the compat property, to make > sure qemu machine types for 2.1 & older continue to have usb1 mouse+kbd > by default. >=20 > The property for the tablet is in hw/i386/pc_piix.c, have a look there > how to do it. The compat properties for more recent machine types live > in a header file (include/hw/i386/pc.h) so they can be shared between pc > and q35. I gave mouse and kbd the same treatment as tablet has in hw/i386/pc_piix.c. Speaking about properties do I need to add something for display and head properties? tablet adds both of them and they seem to be used together, however keyboard only had display, and I added neither for mouse. >=20 > Oh, and the patch history should not be in the commit message. You can > add the history as notes (see 'git notes'). 'git format-patch' will use > three dashes to separate the notes and 'git am' will strip them off so > they appear on the list message but not in the commit log. Adding the > tree dashes separator to the commit message will work too, at least as > long as you don't send pull requests (in which case 'git am' would have > no chance to strip off the notes). OK I'll move these out of commit messages. thanks, jan >=20 > cheers, > Gerd >=20 >=20 --=-lz2A9sygcnTvFOLtFKYF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJUJXuBAAoJEOCQZixVs7KB5ZsQALLAx6hin5P6aCvX15qBKEEu kM3p+m8D4oBKoEDZOVQneX2CTTjgcx+ufHf1KdV11HN1MwR12yXrbFNb7Co9XIJB rTJtiXwGHmmMQlJ429xj6FwNoV07jecv90+S4TIJHpU2XTli8vVNY4pc2I3B89QJ d0sxJfS4iuwL5oKW7R7qm6fcsVELnedYCalRC+hVKObk1Tz1DA+ElP/GSdHlpciU 81fSLFwAkKWGyzebfKGRd1pB3MUUYXsDvv4HDKjLt8ZUfbEPoizEEn9BBCRZjxYr eKQUfK4aaQ9Y3t9SWJT4k2It8WEzZWdUpYWfEpoVAM1Lt9s7rjUtR2aTc/AZQw5V 91V/6MKqKdk1R03Lekp0ZtBN5+via50guACIjhRBnrPcVa3DshKg8qWgXriNofoX BGRVLJs7SQ/7LxRForbw+KGGMKE1PFJ4aIF76tN/QLF3AesWYC4yEiLY+J3Eerqb bQ9TBCrxnWOClx7ogjHGVja6R0IK2LHquj1sSg24RCyn2irH4GPHv+MAe9IaF+UY 5crnSwRh/mxowJIykV4Y4n5XCn0S0am+BcD1WkWQDarkxcMcFbGc+jBAn2gjQM/c al6REFWzIiAZreUXOXakL9dXAv0ok4KmALlQZ38dm9CMOEhxbyoU+vA1G77/Ixe0 byMD1tKyi3JyLzAoOvQ0 =fKus -----END PGP SIGNATURE----- --=-lz2A9sygcnTvFOLtFKYF--