From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael Mueller" <mimu@linux.vnet.ibm.com>,
"Marcel Apfelbaum" <marcel.a@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Alexander Graf" <agraf@suse.de>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH v3 17/17] kvm: Make KVMState be the TYPE_KVM_ACCEL instance struct
Date: Fri, 26 Sep 2014 17:45:32 -0300 [thread overview]
Message-ID: <1411764332-23265-18-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1411764332-23265-1-git-send-email-ehabkost@redhat.com>
Now that we create an accel object before calling machine_init, we can
simply use the accel object to save all KVMState data, instead of
allocationg KVMState manually.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
kvm-all.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 8de1a83..3ab1b4e 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -75,8 +75,10 @@ typedef struct KVMSlot
typedef struct kvm_dirty_log KVMDirtyLog;
-struct KVMState
+typedef struct KVMState
{
+ AccelState parent_obj;
+
KVMSlot *slots;
int nr_slots;
int fd;
@@ -109,10 +111,13 @@ struct KVMState
QTAILQ_HEAD(msi_hashtab, KVMMSIRoute) msi_hashtab[KVM_MSI_HASHTAB_SIZE];
bool direct_msi;
#endif
-};
+} KVMState;
#define TYPE_KVM_ACCEL ACCEL_CLASS_NAME("kvm")
+#define KVM_STATE(obj) \
+ OBJECT_CHECK(KVMState, (obj), TYPE_KVM_ACCEL)
+
KVMState *kvm_state;
bool kvm_kernel_irqchip;
bool kvm_async_interrupts_allowed;
@@ -1405,7 +1410,7 @@ static int kvm_init(MachineState *ms)
int i, type = 0;
const char *kvm_type;
- s = g_malloc0(sizeof(KVMState));
+ s = KVM_STATE(ms->accelerator);
/*
* On systems where the kernel can support different base page
@@ -1594,7 +1599,6 @@ err:
close(s->fd);
}
g_free(s->slots);
- g_free(s);
return ret;
}
@@ -2244,6 +2248,7 @@ static const TypeInfo kvm_accel_type = {
.name = TYPE_KVM_ACCEL,
.parent = TYPE_ACCEL,
.class_init = kvm_accel_class_init,
+ .instance_size = sizeof(KVMState),
};
static void kvm_type_init(void)
--
1.9.3
next prev parent reply other threads:[~2014-09-26 20:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 20:45 [Qemu-devel] [PATCH v3 00/17] QOMify accelerator code Eduardo Habkost
2014-09-26 20:45 ` [Qemu-devel] [PATCH v3 01/17] vl.c: Small coding style fix Eduardo Habkost
2014-09-26 20:45 ` [Qemu-devel] [PATCH v3 02/17] accel: Move accel code to accel.c Eduardo Habkost
2014-09-26 20:45 ` [Qemu-devel] [PATCH v3 03/17] accel: Create AccelType typedef Eduardo Habkost
2014-09-26 20:45 ` [Qemu-devel] [PATCH v3 04/17] accel: Simplify configure_accelerator() using AccelType *acc variable Eduardo Habkost
2014-09-26 20:45 ` [Qemu-devel] [PATCH v3 05/17] accel: Move accel name lookup to separate function Eduardo Habkost
2014-09-26 20:45 ` [Qemu-devel] [PATCH v3 06/17] accel: Use QOM classes for accel types Eduardo Habkost
2014-09-26 20:45 ` [Qemu-devel] [PATCH v3 07/17] accel: Make AccelClass.available() optional Eduardo Habkost
2014-09-26 20:45 ` [Qemu-devel] [PATCH v3 08/17] accel: Report unknown accelerator as "not found" instead of "does not exist" Eduardo Habkost
2014-09-26 20:45 ` [Qemu-devel] [PATCH v3 09/17] accel: Move KVM accel registration to kvm-all.c Eduardo Habkost
2014-09-26 20:45 ` [Qemu-devel] [PATCH v3 10/17] accel: Move Xen registration code to xen-common.c Eduardo Habkost
2014-09-26 20:45 ` [Qemu-devel] [PATCH v3 11/17] accel: Move qtest accel registration to qtest.c Eduardo Habkost
2014-09-26 20:45 ` [Qemu-devel] [PATCH v3 12/17] accel: Remove tcg_available() function Eduardo Habkost
2014-09-26 20:45 ` [Qemu-devel] [PATCH v3 13/17] accel: Move accel init/allowed code to separate function Eduardo Habkost
2014-09-26 20:45 ` [Qemu-devel] [PATCH v3 14/17] accel: Rename 'init' method to 'init_machine' Eduardo Habkost
2014-09-26 20:45 ` [Qemu-devel] [PATCH v3 15/17] accel: Pass MachineState object to accel init functions Eduardo Habkost
2014-09-26 20:45 ` [Qemu-devel] [PATCH v3 16/17] accel: Create accel object when initializing machine Eduardo Habkost
2014-09-26 20:45 ` Eduardo Habkost [this message]
2014-09-29 21:56 ` [Qemu-devel] [PATCH v3 00/17] QOMify accelerator code Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411764332-23265-18-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=marcel.a@redhat.com \
--cc=mimu@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).