qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] gtk: add support for the Pause key
@ 2014-09-16 14:04 Martin Decky
  2014-09-28 14:54 ` [Qemu-devel] Ping " Martin Decky
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Decky @ 2014-09-16 14:04 UTC (permalink / raw)
  To: qemu-devel; +Cc: Gerd Hoffmann, Anthony Liguori

Special handing of the Pause key. Implemented in a similar way as in
ui/sdl.c.

Signed-off-by: Martin Decky <martin@decky.cz>
---
  ui/gtk.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/ui/gtk.c b/ui/gtk.c
index 2345d7e..e52cab1 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -931,6 +931,12 @@ static gboolean gd_key_event(GtkWidget *widget, GdkEventKey *key, void *opaque)
      int qemu_keycode;
      int i;
  
+    if (key->keyval == GDK_KEY_Pause) {
+        qemu_input_event_send_key_qcode(vc->gfx.dcl.con, Q_KEY_CODE_PAUSE,
+                                        key->type == GDK_KEY_PRESS);
+        return TRUE;
+    }
+
      qemu_keycode = gd_map_keycode(s, gtk_widget_get_display(widget),
                                    gdk_keycode);
  
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Qemu-devel] Ping [PATCH] gtk: add support for the Pause key
  2014-09-16 14:04 [Qemu-devel] [PATCH] gtk: add support for the Pause key Martin Decky
@ 2014-09-28 14:54 ` Martin Decky
  2014-09-29  8:22   ` Gerd Hoffmann
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Decky @ 2014-09-28 14:54 UTC (permalink / raw)
  To: qemu-devel; +Cc: Gerd Hoffmann, Anthony Liguori

http://patchwork.ozlabs.org/patch/390074/

It is a rather simple patch adding support for the Pause key in the GTK
UI. It should not cause any regressions. Please apply.  Thanks.


M.D.

On 16-09-2014 16:04, Martin Decky wrote:
> Special handing of the Pause key. Implemented in a similar way as in
> ui/sdl.c.
>
> Signed-off-by: Martin Decky <martin@decky.cz>
> ---
>   ui/gtk.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/ui/gtk.c b/ui/gtk.c
> index 2345d7e..e52cab1 100644
> --- a/ui/gtk.c
> +++ b/ui/gtk.c
> @@ -931,6 +931,12 @@ static gboolean gd_key_event(GtkWidget *widget, GdkEventKey *key, void *opaque)
>       int qemu_keycode;
>       int i;
>
> +    if (key->keyval == GDK_KEY_Pause) {
> +        qemu_input_event_send_key_qcode(vc->gfx.dcl.con, Q_KEY_CODE_PAUSE,
> +                                        key->type == GDK_KEY_PRESS);
> +        return TRUE;
> +    }
> +
>       qemu_keycode = gd_map_keycode(s, gtk_widget_get_display(widget),
>                                     gdk_keycode);
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] Ping [PATCH] gtk: add support for the Pause key
  2014-09-28 14:54 ` [Qemu-devel] Ping " Martin Decky
@ 2014-09-29  8:22   ` Gerd Hoffmann
  0 siblings, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2014-09-29  8:22 UTC (permalink / raw)
  To: Martin Decky; +Cc: qemu-devel, Anthony Liguori

On So, 2014-09-28 at 16:54 +0200, Martin Decky wrote:
> http://patchwork.ozlabs.org/patch/390074/
> 
> It is a rather simple patch adding support for the Pause key in the GTK
> UI. It should not cause any regressions. Please apply.  Thanks.

Patch looks good but doesn't apply any more.  Can you please rebase &
resend?

thanks,
  Gerd

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-09-29  8:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-16 14:04 [Qemu-devel] [PATCH] gtk: add support for the Pause key Martin Decky
2014-09-28 14:54 ` [Qemu-devel] Ping " Martin Decky
2014-09-29  8:22   ` Gerd Hoffmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).