From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYWyD-0002nf-1H for qemu-devel@nongnu.org; Mon, 29 Sep 2014 05:10:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYWy6-0001QX-Sd for qemu-devel@nongnu.org; Mon, 29 Sep 2014 05:10:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58534) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYWy6-0001Hg-LY for qemu-devel@nongnu.org; Mon, 29 Sep 2014 05:10:06 -0400 Message-ID: <1411981796.32643.13.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Mon, 29 Sep 2014 11:09:56 +0200 In-Reply-To: <20140927032909.GA3029@air> References: <1411726999-26513-1-git-send-email-akong@redhat.com> <1411727810.865.6.camel@nilsson.home.kraxel.org> <20140926105320.GA11893@air.nay.redhat.com> <1411730645.865.8.camel@nilsson.home.kraxel.org> <20140927032909.GA3029@air> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] ui/input: fix event emitting of repeated combined keys List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: Marcelo Tosatti , qemu-devel@nongnu.org, aliguori@amazon.com, lcapitulino@redhat.com Hi, > It doesn't matter, so users might release the modifier key or not. > we should make both works > > 1) > sendkey Ctrl-Scroll > sendkey Ctrl-Scroll Good to know this works. > 2) > sendkey Ctrl-Scroll-Scroll Why? This tries to squeeze something into the sendkey interface which it doesn't was designed for, and IMO this isn't a good idea, especially if we have something better at hand (marcelos patch). cheers, Gerd